Fix IP anonymization for ipv6 client addresses #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, if a client had an ipv6 address the creation of the
magic link would fail with this error:
```
invalid input syntax for type inet: "0"
```
This is because the original ip anonymization code below assumed the ip was an
ipv4 address. When an ipv6 address was given, the ip address would get
mangled into '0' and subsequently fail the validation of the GenericIPAddressField.
```py
client_ip[:client_ip.rfind('.')+1] + '0'
```
This commit adds support for anonymizing ipv6 addresses. For these addresses
the last 80 bits are zeroed out. This seems to be the recommended practise,
as also used by Google Analytics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @pyepye first of all thanks for this great library! Your library made implementing magic links a breeze!
This PR fixes ip anonymization for ipv6 clients.
Before this fix, if a client had an ipv6 address the creation of the
magic link would fail with this error:
This is because the original ip anonymization code below assumed the ip was an
ipv4 address. When an ipv6 address was given, the ip address would get
mangled into '0' and subsequently fail the validation of the GenericIPAddressField.
This commit adds support for anonymizing ipv6 addresses. For these addresses
the last 80 bits are zeroed out. This seems to be the recommended practise,
as also used by Google Analytics.