Fix TmpDir to match POSIX #1462
Conversation
Fizzadar
left a comment
Fizzadar
left a comment
There was a problem hiding this comment.
Way nicer, slight change needed for backwards compatibiity (sorry) 🙏
src/pyinfra/facts/server.py
Outdated
| elif [ -n "$TEMP" ] && [ -d "$TEMP" ] && [ -w "$TEMP" ]; then | ||
| echo "$TEMP" | ||
| else | ||
| echo "/tmp" |
There was a problem hiding this comment.
We shouldn't provide a default here, the fallback is specified at the config level currently (https://github.com/pyinfra-dev/pyinfra/blob/3.x/src/pyinfra/api/config.py#L29).
To be honest I think this way is nicer, but we can't break the config for backwards compatibility so if no matching env vars the fact still needs to return a blank string.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
pushed the change, let me know @Fizzadar
|
Funny note - was just in go docs and spotted Go doesn't respect POSIX either: https://pkg.go.dev/os#TempDir |
3 participants
Fix #1458
According to POSIX standards, checks environment variables in this order:
1. TMPDIR (if set and accessible)
2. TMP (if set and accessible)
3. TEMP (if set and accessible)
4. Falls back to /tmp
3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)