Skip to content

Conversation

@wowi42
Copy link
Contributor

@wowi42 wowi42 commented Sep 26, 2025

The issue was that the test_get_sftp_fail test was failing because of a memoization cache problem. The get_file_transfer_connection method in the SSH connector is decorated with @memoize, which caches the result of the method call. When running multiple tests, if the method was successfully called in a previous test, it would return the cached result instead of executing again and potentially raising the expected SSHException

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)

Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉 thank you for tracking this down @wowi42! Been a total pain to get rid of all the CI wonkiness caused by this, glad you found what is hopefully the last case!

@Fizzadar Fizzadar merged commit dfcd97b into pyinfra-dev:3.x Oct 1, 2025
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants