Speedup compilation #1607
Draft
Speedup compilation #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ricardoV94
force-pushed
the
speedup_compilation
branch
from
dba6c55 to
9383064
Compare
Not using `__call__` avoids the test_value computation
It's not really needed as we never expand on the new nodes
The change in number of fused kernels has to do with the order of iteration, and could be replicated in the old approach by iterating in topological order. It was an accident that it happen to visit in an order where it connected two branches, instead of keeping them separate. The underlying limitation already existed and is described in pymc-devs#249
ricardoV94
force-pushed
the
speedup_compilation
branch
from
53dec15 to
155952e
Compare
This is much faster to create/compile and produces better code for the most ubiquitous Op in PyTensor
TODO: Do same for ScalarTypes
…ype and then casting them
This should be cleaned up into nicer git commits
This reverts commit ae43c14. Breaks the @pytensor_jit example
ricardoV94
force-pushed
the
speedup_compilation
branch
from
155952e to
330a1e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review!, includes commits that have to be removed or from other PRs