Add MyPy Checks

[juanitorduz]

Closes #66

Add MyPy Checks

---

📚 Documentation preview 📚: https://causalpy--556.org.readthedocs.build/en/556/

[codecov]

Codecov Report

❌ Patch coverage is 94.11765% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.40%. Comparing base (bc2fbae) to head (225a498).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
causalpy/pymc_models.py	82.75%	5 Missing ⚠️
causalpy/data/simulate_data.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   96.48%   96.40%   -0.09%     
==========================================
  Files          29       29              
  Lines        2703     2724      +21     
==========================================
+ Hits         2608     2626      +18     
- Misses         95       98       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[drbenvincent]

Cool @juanitorduz. This area is a bit fuzzy for me, can you just mention if or how this might impact a plan by @louismagowan to implement type checking by ty #378 (comment) ? Presumably it's one of the other?

[juanitorduz]

Cool @juanitorduz. This area is a bit fuzzy for me, can you just mention if or how this might impact a plan by @louismagowan to implement type checking by ty #378 (comment) ? Presumably it's one of the other?

I think after we merge this one we can simply replace mypy by ty. This PR addresses a more fundamental issue which is making types consistent. The rest is about which tool we use to check it

[juanitorduz]

Also, I missed #378 (comment) 🤦 . Sorry! Do you wanna wait and close this PR?

[drbenvincent]

Also, I missed #378 (comment) 🤦 . Sorry! Do you wanna wait and close this PR?

No I think what you say here is very sensible.

This PR addresses a more fundamental issue which is making types consistent. The rest is about which tool we use to check it

Just in the middle of something, but will test this out locally and review shortly :)

[juanitorduz]

"trust me bro, it works" 😆

[juanitorduz]

@drbenvincent In #557 I actually add type hints (via GEMINI) to all the code base.

[drbenvincent]

Ran locally and we have 4 errors:

causalpy/data/simulate_data.py:183: error: Unsupported operand types for - ("ExtensionArray" and "int")  [operator]
causalpy/data/simulate_data.py:183: note: Left operand is of type "ExtensionArray | ndarray[tuple[Any, ...], dtype[Any]]"
causalpy/data/simulate_data.py:266: error: Argument 1 to "outcome" has incompatible type "Series[Any]"; expected "ndarray[tuple[Any, ...], dtype[Any]]"  [arg-type]
causalpy/data/simulate_data.py:271: error: Argument 6 to "outcome" has incompatible type "Series[Any]"; expected "ndarray[tuple[Any, ...], dtype[Any]]"  [arg-type]
causalpy/data/simulate_data.py:272: error: Argument 7 to "outcome" has incompatible type "Series[Any]"; expected "ndarray[tuple[Any, ...], dtype[Any]]"  [arg-type]
Found 4 errors in 1 file (checked 32 source files)

[juanitorduz]

yes, I will fix this becasue I need to rebase the PR from #544

[juanitorduz]

@drbenvincent Its green now

[juanitorduz]

Ok! Merged the approved PR #557 to this one and I think we are now ready to merge to main 💪

[juanitorduz]

Thank you @drbenvincent !