Use dataclass to add type annotations to Extension so that it can easily be extended in setuptools.
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an unrelated error in I have rebased this PR on top of #374, so that we can see if the main log fails on not in the majority of the CI workers. Now the same unrelated errors as in #374 (comment) can be found. |
abravalheri
force-pushed
the
type-extension
branch
from
ae2a2cc to
37447a4
Compare
abravalheri
commented
Jul 11, 2025
| # function) -- authors of new compiler interface classes are | ||
| # responsible for updating 'compiler_class'! | ||
| compiler_type: ClassVar[str] = None # type: ignore[assignment] | ||
| compiler_type: ClassVar[str] = None |
2 tasks
abravalheri
commented
Jul 20, 2025
| Please remove unknown `Extension` options: {','.join(extra)} | ||
| this kind of usage is deprecated and may cause errors in the future. | ||
| """ | ||
| warnings.warn(msg) |
There was a problem hiding this comment.
If/when lenient behaviour is not needed the whole custom __init__ can be removed (and the classes _Extension/Extension can be unified.
abravalheri
commented
Jul 20, 2025
| """ | ||
|
|
||
|
|
||
| # Legal keyword arguments for the Extension constructor |
There was a problem hiding this comment.
The phrase Legal keyword arguments for the Extension constructorwas copied from core.py (not sure if `"legal"is the best term to use).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pypa/setuptools#5022, there is an effort to add type annotations to
setuptools.extension.Extension.However, right now it basically requires repeating all the
__init__arguments that are already specified indistutils.extension.Extensionand all the type annotations.If any argument changes (added/removed/changed type annotation), that needs to be repeated in
setuptools.There is a discussion in https://github.com/pypa/setuptools/pull/5022/files#r2124429494 about how would it be possible to avoid this duplication and need for manual synchronisation.
This PR is an attempt to use
dataclassfor that.I have experimented with other approaches (like attempting to use a TypedDict), but in the end of the day, this approach is what seems to me the most promising.
If I am not mistaken, this should allow backward compatibility. Type checkers are likely to start catching unknown keyword arguments, but I think that is a good thing.
On a related not, I did modify the warning to mention using unknown keywords is deprecated, the reasoning is that removing this lenient behaviour simplifies a lot of stuff and we can use dataclasses by the book.
The docstrings for the properties were basically moved from the existing class docstring.