Replace inappropriate international email test data with neutral example #5055
Conversation
|
@jaraco , if possible can you please review this PR |
|
@sharktide , I noticed that you've approved the PR, but it hasn't been merged into the main branch yet. |
I don't have write permissions to this repository. Someone else (eg. a core dev) will have to merge it |
|
@abravalheri , This PR has already been reviewed and approved by @sharktide, but he doesn't have the necessary permissions to merge it. Could you please go ahead and merge it, as the review is complete and the pipeline has passed? |
|
@jaraco, if possible, could you please merge this PR? It has been reviewed and approved by Sharktide, but they do not have the necessary permissions to merge it. And it has been pending from long time |
| ] | ||
| maintainers = [ | ||
| {name = "Степан Бандера", email = "криївка@оун-упа.укр"}, | ||
| {name = "Ankit Ahlawat", email = "[email protected]"}, |
There was a problem hiding this comment.
Aside from any discussion about whether someone is a good name to use or not, wouldn't it be better to keep using non-ANSI chars here for testing ? I see you did so for the email below. Does this person's (your?) name also translate to (Hindi?) characters? (Google translate gives me अंकित अहलावत)
There was a problem hiding this comment.
@Avasam Thank you for the suggestion! I’ve updated the maintainer’s name to use Hindi characters (अंकित अहलावत) to ensure consistency with non-ASCII testing.
| 'Ankit Ahlawat <अंकित@उदाहरण.भारत>', | ||
| marks=pytest.mark.xfail( | ||
| reason="CPython's `email.headerregistry.Address` only supports " | ||
| 'RFC 5322, as of Nov 10, 2022 and latest Python 3.11.0', |
There was a problem hiding this comment.
Worth updating the "as of" date and python version
There was a problem hiding this comment.
Thanks! That makes sense — I’ve updated the reason to reflect the current date and Python version (Oct 20, 2025 and Python 3.13.0).
There was a problem hiding this comment.
Please have a look now.
4 participants
Issue #5050
Bug Description:
The code contains inappropriate international email test data, including references to the Ukrainian nationalist Stepan Bandera and an email address containing a nationalist slogan. This content is unsuitable and should be replaced with neutral examples to maintain professionalism and inclusivity.