Remove license metadata from pyproject.toml to avoid misleading SPDX compliance
#5116
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the code for `setuptools` itself be distributed under MIT, setuptools includes third-party code with other licenses. Adding `license = "MIT"` to `pyproject.toml` is problematic under the lenses of PEP 639 because it may imply that all the files distributed by setuptools are licensed under MIT which is not the case. By removing that metadata, setuptools should be "in the clear".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that the
setuptoolsown code is distributed under the MIT license, the project includes third-party code under different licenses.For some downstream users, adding
license = "MIT"topyproject.tomlis problematic under the lenses of PEP 639 because it may imply that all the files distributed by setuptools are licensed under MIT, which is not the case. See discussion in #5049.By removing that metadata, setuptools should be "in the clear".
I understand that consumers of the package would prefer a complete SPDX license expression. However, as explained in #5049, this is currently not viable. In the future, setuptools may adopt SPDX expressions once tools exist in the Python ecosystem that can automatically compute them from a given set of files and directories.
For the time being, consumers interested in knowing license information should refer to the text in the license files being distributed.
Summary of changes
Closes #5049
Pull Request Checklist
newsfragments/.(See documentation for details)