Add timeout when receiver is not found after 5 seconds#9
Open
moan0s wants to merge 2 commits intopyreiz:masterfrom
Open
Add timeout when receiver is not found after 5 seconds#9moan0s wants to merge 2 commits intopyreiz:masterfrom
moan0s wants to merge 2 commits intopyreiz:masterfrom
Conversation
Member
|
The receiver looks for the localite_marker stream using resolve_stream from pylsl. This function has an inbuilt waiting time, that is, how long it looks before returning an empty list. It always returns after the waittime. That means: If the timeout is different than the wait-time, that'll cause issues. You might want to forward the timeout argument via the Receiver to resolve_streams, and catch the empty list in the Receiver (e.g. here instead of the Coil. Alternatively, skip timeout completely, and just catch the empty list after the default wait time. That'll do the job of informing the examiner with an more informative error message. https://github.com/labstreaminglayer/liblsl-Python/blob/master/pylsl/pylsl.py#L535-L538 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to solve the problem that a user not familiar with the setup forgot to activate the localite-flow but has a hard time of finding the source of the problem