Develop update for the prelim bug #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial movement of the GFZ download to methods.
Added general functions to download and list GFZ and SWPC recent data.
Added a separate Instrument module for Ap data.
Updated to use the common listing and download functions.
Added a function to find the correct data path for a given instrument.
Grouped all the GFZ functions into their own method sub-module.
Grouped all the SWPC-specific functions into their own sub-module.
Removed the GFZ and SWPC functions that were used to create their own sub-modules.
Added new tags to the Kp, Ap, and F10.7 Instruments, using the new SWPC functions to handle downloading and listing the data files.
Added new Instrument modules to hold the data that was formerly being stored in other Instruments or thrown away.
Moved the F10.7 methods for SWPC data to the SWPC method sub-module.
Removed the non-F10.7 data from the daily and prelim files from the F10.7 Instrument.
Created new Instruments for the SSN and solar magnetic field data.
Added solar flare tags for the prelim and daily DSD files.
Fixed bugs identified through unit testing including: - typos in function and module names, - incorrect output assignment, - added directory creation, - added missing tags in supporting functions, and - corrected filename construction.
Updated the format of the Kp definitive test file.
Added unit test for the Bartel metadata initialization function.
Improved the logging warning to be more descriptive.
Added unit test coverage for many of the uncovered lines.
Added a summary of the changes to the log.
Updated the contributing guidelines to contain a note on when multiple Instrument downloads should be supported.
Updated the API to include the new sub-modules.
Added a multi-download example with a table containing all the Instruments that currently use this functionality.
Removed extra whitespace from the test file.
Added a cleanup command for the logging test class.
Attempt windows fix using pysat test class.
Attempt local file cleanup without tempdir.
Fixed the supported instrument headers and added the new example to the examples table of contents.
Removed an old attribute name.
Added new instruments for the GFZ provided apo and Hpo indices.
Added the GFZ data option to the F10.7 and SSN instruments.
Updated the instrument imports to include the new instruments.
Updated the supported instruments in the documentation to include the new apo and Hpo instruments.
Updated changelog to include the new instruments and functions.
Fixed the name of the download function to be correct.
Updated the GFZ Hpo link in the docs.
Added missing `format_str` to the SSN instrument.
Updated the docstring for `combine_f107` to include the new Instrument tag.
Fixed the combine test to include the 'now'-'obs' GFZ F10.7 data.
Removed an extra space.
Fixed the spelling to be a word that makes sense in context.
Added a list with descriptions for the inst IDs.
Expanded instruments to include all GFZ indices
Added acknowledgements and references for auroral electrojet indices.
Added a download function for the LASP predictions data.
Updated the LASP Dst downloads to use the general LASP function.
Added unit tests for the auroral electrojet functions.
Added auroral electrojet index instruments for the LASP prediction datasets.
Updated the supported instruments to include the auroral electrojet indices.
Added the new instruments and functions to the changelog.
Added imports for the new instrument methods, `auroral_electrojet` and `lasp`.
Removed the requests module from Dst, as it is no longer needed here with the new download function.
Fixed the name in the AE Instrument.
Fixed Instrument `name` references in the docstrings.
LASP auroral index prediction data
jklenzing
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needed to correctly resolve conflicts in #120
Type of change
Please delete options that are not relevant.
to not work as expected)
How Has This Been Tested?
N/A
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release