compat: a few minor cleanups #13767
Merged
compat: a few minor cleanups #13767
+18
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe it's not ideal but that's the current reality, and I wouldn't like to break tradition by renaming the file.
The file is definitely not executable.
Use the upstream implementation, so we can easily drop our own impl when we drop Python 3.10.
Currently defined in `_pytest.assertion.util`, but then imported from `_pytest.terminal`, so makes sense to move it to the general utils place.
Pierre-Sassoulas
approved these changes
Sep 30, 2025
Comment on lines
-616
to
-621
|
|
||
|
|
||
| def running_on_ci() -> bool: | ||
| """Check if we're currently running on a CI system.""" | ||
| env_vars = ["CI", "BUILD_NUMBER"] | ||
| return any(var in os.environ for var in env_vars) |
There was a problem hiding this comment.
Great, this is helping for my current refactor on #13762 a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commits for explanations.