Skip to content

Conversation

@devin-ai-integration
Copy link
Contributor

Description

Added a security warning callout to the Pyth Pro "Subscribe to Prices" page to alert users not to expose access tokens in frontend applications. The callout emphasizes that access tokens should only be used in secure backend environments.

Type of Change

  • New Page
  • Page update/improvement
  • Fix typo/grammar
  • Restructure/reorganize content
  • Update links/references
  • Other (please describe):

Areas Affected

  • pages/price-feeds/pro/subscribe-price-updates.mdx - Added security warning callout after step 1 (acquiring access token)

Checklist

  • I ran pre-commit run --all-files to check for linting errors
  • I have reviewed my changes for clarity and accuracy
  • All links are valid and working
  • Images (if any) are properly formatted and include alt text
  • Code examples (if any) are complete and functional
  • Content follows the established style guide
  • Changes are properly formatted in Markdown
  • Preview renders correctly in development environment (unable to test locally)

Human Review Checklist

Please verify:

  • The callout renders correctly with the warning emoji and styling
  • The placement after step 1 is appropriate (alternative: could be placed at step 3 where token is used in code)
  • The wording is clear and matches the documentation's tone
  • The warning provides sufficient guidance without being overly verbose

Related Issues

This addresses a security concern raised by the team to prevent users from accidentally exposing access tokens in client-side code.

Additional Notes

This is a temporary callout. A dedicated best practices page for Pyth Pro may be added in the future to provide more comprehensive security guidance.

Contributor Information

@devin-ai-integration
Copy link
Contributor Author

Prompt hidden (unlisted session)

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 21, 2025 3:46pm
documentation Error Error Nov 21, 2025 3:46pm

Comment on lines 38 to 39
environments. Exposing tokens in frontend code makes them publicly accessible
and compromises your account security.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this sentence to: "Exposing tokens in frontend code makes them publicly accessible
and is a violation of our terms of service."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I'll update the wording to reference the terms of service violation.

@tejasbadadare tejasbadadare merged commit baf882c into main Nov 21, 2025
4 of 5 checks passed
@tejasbadadare tejasbadadare deleted the devin/1763737898-add-pyth-pro-access-token-security-callout branch November 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants