feat: Add RaffleForGood - Decentralized raffle system with Pyth Entropy #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solid Pyth Entropy integration. The request-callback flow is implemented correctly with proper state management, fee handling, and security checks. Binary search for winner selection (O(log n)) is smart - scales to millions of participants efficiently. Code is clean and follows OpenZeppelin best practices (ReentrancyGuard, PullPayment).
Minor Issues, the forceSelectWinner() function bypasses Pyth Entropy - probably for testing but could be confusing. Consider removing it or clearly marking as test-only. Also, the commented-out time validation in requestEntropy() should either be removed or explained.
my main repo: https://github.com/NicoCaz/eth-global-hackathon
visit: https://tanly.app/