-
-
Notifications
You must be signed in to change notification settings - Fork 256
Add Support for aliases repositories & default org in .gh repo command #1711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Support for aliases repositories & default org in .gh repo command #1711
Conversation
Sacul0457
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good practice to cancel the cog when unloading. I'm believe it's done here too (not too sure), but it can lead to some problems because a task isn't automatically cancelled when the cog is unloaded.
async def cog_unload(self):
self.refresh_repos.cancel()
It wasn't done, I had no idea that was best practice but I have implemented it now. |
Sacul0457
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for addressing the reviews earlier, these are just some minor ones
So far, it looks good to me, I'll review once more after this change
onerandomusername
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far liking the general implementation. These comments are more about code style. I previously began a review but it looks like GitHub ate my comments so I might have more to add later.
Co-authored-by: Sacul <[email protected]>
…tent throughout Co-authored-by: Sacul <[email protected]>
|
this is shaping up nicely, I don't have any more changes:) |
Co-authored-by: z <[email protected]>
Relevant Issues
Closes #1710
Description
bot/resources/utilities/stored_repos.json.gh repoto support repository aliasesI Did: