-
-
Notifications
You must be signed in to change notification settings - Fork 138
Poetry to uv migration #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry to uv migration #1549
Conversation
❌ Deploy Preview for pydis-static failed. Why did it fail? →
|
❌ Deploy Preview for pydis-static failed. Why did it fail? →
|
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
3673eed
to
3164711
Compare
Corrected dockerfile to copy uv over from build step Probably fine, right? (I forgot how to dockerfile, please forgive me)
Removed PyCharm guide due to it containing the poetry plugin and there isn't a direct alternative to that besides just creating a virtual environment from uv and using that in PyCharm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request migrates the project from Poetry to uv as the dependency management tool. The migration involves updating configuration files, documentation, CI workflows, and Docker setup to use uv instead of Poetry throughout the project.
- Replaces Poetry configuration with uv's PEP 621 compliant
pyproject.toml
format - Updates all documentation and guides to reference uv commands instead of Poetry commands
- Modernizes Docker build process with multi-stage builds and uv integration
Reviewed Changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
pyproject.toml | Complete migration from Poetry format to PEP 621 standard with uv configuration |
Dockerfile | Multi-stage Docker build using uv for dependency management |
.github/workflows/lint-test.yaml | CI workflow updated to use uv instead of Poetry |
.github/dependabot.yml | Dependabot configuration switched to uv ecosystem |
.pre-commit-config.yaml | Pre-commit hooks updated to use uv commands |
static-builds/README.md | Build instructions updated from Poetry to uv |
Multiple guide files | Documentation updated to reference uv instead of Poetry |
Dockerfile
Outdated
RUN pip install --no-cache-dir --upgrade pip setuptools wheel \ | ||
&& python -m venv .venv |
Copilot
AI
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Installing pip, setuptools, and wheel is unnecessary when using uv, as uv handles package building internally. This adds unnecessary overhead to the build process.
RUN pip install --no-cache-dir --upgrade pip setuptools wheel \ | |
&& python -m venv .venv | |
RUN python -m venv .venv |
Copilot uses AI. Check for mistakes.
Dockerfile
Outdated
RUN pip install --no-cache-dir --upgrade pip setuptools wheel \ | ||
&& python -m venv .venv |
Copilot
AI
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a virtual environment manually is redundant since uv sync
creates and manages the virtual environment automatically.
RUN pip install --no-cache-dir --upgrade pip setuptools wheel \ | |
&& python -m venv .venv | |
RUN pip install --no-cache-dir --upgrade pip setuptools wheel |
Copilot uses AI. Check for mistakes.
/dev/null is webscale |
/merge |
When I run this locally, I get the following error:
Adding |
Docker, CI, and pyproject.toml have poetry replaced with uv. All guides have poetry replaced with uv. PyCharm portion of installing project dependencies is (temporarily?) removed since I'm not aware of a uv equivalent of the jetbrains poetry plugin.