Skip to content

Fix Issue #906: Resolve Interval.in_words() incompatibility with Python native datetime.datetime. #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Issue #906: Resolve Interval.in_words() incompatibility with Python native datetime.datetime. #921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/pendulum/interval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,23 +194,23 @@ def months(self) -> int:

@property
def weeks(self) -> int:
return abs(self._delta.days) // 7 * self._sign(self._delta.days)
return abs(self._days) // 7 * self._sign(self._days)

@property
def days(self) -> int:
return self._days

@property
def remaining_days(self) -> int:
return abs(self._delta.days) % 7 * self._sign(self._days)
return abs(self._days) % 7 * self._sign(self._days)

@property
def hours(self) -> int:
return self._delta.hours
return abs(int(self.total_seconds()) // 3600 % 24) * self._sign(self.total_seconds())

@property
def minutes(self) -> int:
return self._delta.minutes
return abs(int(self.total_seconds()) // 60 % 60) * self._sign(self.total_seconds())

@property
def start(self) -> _T:
Expand Down
Loading