Skip to content

platform release is not a version-like marker #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

platform release is not a version-like marker #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
001a3b4
platform release is not a version-like marker
j-baker Jan 27, 2023
1f59eb2
add explicit test for this behaviour
j-baker Jan 27, 2023
99a466d
Move unit test closer to original problem test to make more clear if …
j-baker Jan 27, 2023
7685cc0
comment
j-baker Jan 27, 2023
eca89a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 27, 2023
334ef55
Update test_markers.py
j-baker Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/poetry/core/version/markers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ class SingleMarker(BaseMarker):
_VERSION_LIKE_MARKER_NAME = {
"python_version",
"python_full_version",
"platform_release",
}

def __init__(
Expand Down
12 changes: 10 additions & 2 deletions tests/version/test_markers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,8 +902,8 @@ def test_validate(
"marker, env",
[
(
'platform_release >= "9.0" and platform_release < "11.0"',
{"platform_release": "10.0"},
'python_version >= "9.0" and python_version < "11.0"',
{"python_version": "10.0"},
)
],
)
Expand All @@ -913,6 +913,14 @@ def test_parse_version_like_markers(marker: str, env: dict[str, str]) -> None:
assert m.validate(env)


def test_environment_marker_examples() -> None:
# These are the platform_release examples in PEP-508, so should always parse
parse_marker(
'platform_release == "3.14.1-x86_64-linode39" or platform_release == "14.5.0"'
' or platform_release == "1.8.0_51"'
)


@pytest.mark.parametrize(
"marker, expected",
[
Expand Down