Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 16, 2025

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.
@vstinner
Copy link
Member Author

@Fidget-Spinner: I blindly replaced Py_TAIL_CALL_INTERP text with _Py_TAIL_CALL_INTERP. I didn't test my change.

@Fidget-Spinner
Copy link
Member

Thanks. I'll approve once CI passes.

@vstinner
Copy link
Member Author

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

@Fidget-Spinner
Copy link
Member

I built Python with tail call on Linux using ./configure --with-tail-call-interp CC=clang LD=clang && make. I checked that ./python -m test test_sys -v still pass.

Don't worry, we have CI for the tail calling interpreter on most platforms, so you can just let it run :)

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Sep 17, 2025
@vstinner
Copy link
Member Author

Ping @Fidget-Spinner

@vstinner
Copy link
Member Author

@hugovk: This change mostly/only makes sense if it's backported to 3.14. Would you accept this late C API change in 3.14? It makes the macro private.

@vstinner
Copy link
Member Author

Maybe it's ok to leave the macro in 3.14 and remove it in 3.15. No one should rely on this macro :-)

@vstinner vstinner merged commit 6504f20 into python:main Sep 18, 2025
82 checks passed
@vstinner vstinner deleted the private_tail_cail branch September 18, 2025 12:33
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6504f20ccedf0b27275327e72698dee5f0c75ba8 3.14

@miss-islington-app miss-islington-app bot assigned vstinner and unassigned hugovk Sep 18, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 18, 2025
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP.

(cherry picked from commit 6504f20)
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2025

GH-139120 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
@vstinner
Copy link
Member Author

@Fidget-Spinner suggested me to merge this change in the main branch, so I did it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants