gh-64490: Tweak AC implementation for **kwds
#139133
Open
+31
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
requested review from
serhiy-storchaka
and removed request for
erlend-aasland
|
Deferring to Serhiy, as this is addressing his review remarks. |
| """ | ||
| self.expect_failure(block, err, lineno=6) | ||
|
|
||
| def test_double_star_after_var_keyword(self): |
There was a problem hiding this comment.
And, is there a test for a single ** without name?
Comment on lines
-1647
to
-1651
| """, """ | ||
| with_kwds | ||
| [ | ||
| **kwds: dict | ||
| ] |
There was a problem hiding this comment.
Could you add also a test for var-positional?
with_varpos
[
*args: tuple
]
If it is an error and has not yet been tested.
If it is an error, and the error message is the same as for keyword arguments here, then it would be reasonable to make the error message for var-keyword the same. Otherwise we can leave a discrepancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses @serhiy-storchaka's comments following initial merge (thank you Serhiy for the reviews!).
A