Skip to content

fix(frontend): Improve low constrast of code blocks and links #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobCoffee merged 3 commits into from
Jan 2, 2026
Merged

fix(frontend): Improve low constrast of code blocks and links #2491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2a422d
Improve color contrast of text in code blocks
tomasr8 Jul 24, 2024
b33d164
Improve color contrast of links inside tables
tomasr8 Jul 24, 2024
60b0fa9
Remove background, padding, margins and adjust green color
tomasr8 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/sass/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ $darkerblue: #1e2933;
$link-color: $blue;
$link-hover: $darkerblue;

$code-green: #11a611;
$code-green: #0d870d;
$default-border-color: $grey-lighter; /* Set a generic border color here to keep them consistent */


Expand Down
10 changes: 5 additions & 5 deletions static/sass/mq.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1651,24 +1651,24 @@ html[xmlns] .slides { display: block; }
padding-top: 1em; }

.about-banner {
background: 120% 0 no-repeat url('../img/landing-about.png?1646853871') transparent;
background: 120% 0 no-repeat url('../img/landing-about.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 3.5em;
margin-bottom: -2.5em; }

.download-for-current-os {
background: 130% 0 no-repeat url('../img/landing-downloads.png?1646853871') transparent;
background: 130% 0 no-repeat url('../img/landing-downloads.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 4em;
margin-bottom: -3em; }

.documentation-banner {
background: 130% 0 no-repeat url('../img/landing-docs.png?1646853871') transparent;
background: 130% 0 no-repeat url('../img/landing-docs.png?1767349471') transparent;
padding-bottom: 1em; }

.community-banner {
text-align: left;
background: 110% 0 no-repeat url('../img/landing-community.png?1646853871') transparent;
background: 110% 0 no-repeat url('../img/landing-community.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 2em;
margin-bottom: -1.25em; }
Expand Down Expand Up @@ -1772,7 +1772,7 @@ html[xmlns] .slides { display: block; }
right: 1em;
width: 210px;
height: 210px;
background: top left no-repeat url('../img/python-logo-large.png?1646853871') transparent; }
background: top left no-repeat url('../img/python-logo-large.png?1767349471') transparent; }
.psf-widget .widget-title, .psf-widget p, .python-needs-you-widget .widget-title, .python-needs-you-widget p {
margin-right: 34.04255%; }

Expand Down
10 changes: 5 additions & 5 deletions static/sass/no-mq.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1359,24 +1359,24 @@ a.button {
padding-top: 1em; }

.about-banner {
background: 120% 0 no-repeat url('../img/landing-about.png?1646853871') transparent;
background: 120% 0 no-repeat url('../img/landing-about.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 3.5em;
margin-bottom: -2.5em; }

.download-for-current-os {
background: 130% 0 no-repeat url('../img/landing-downloads.png?1646853871') transparent;
background: 130% 0 no-repeat url('../img/landing-downloads.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 4em;
margin-bottom: -3em; }

.documentation-banner {
background: 130% 0 no-repeat url('../img/landing-docs.png?1646853871') transparent;
background: 130% 0 no-repeat url('../img/landing-docs.png?1767349471') transparent;
padding-bottom: 1em; }

.community-banner {
text-align: left;
background: 110% 0 no-repeat url('../img/landing-community.png?1646853871') transparent;
background: 110% 0 no-repeat url('../img/landing-community.png?1767349471') transparent;
min-height: 345px;
padding-bottom: 2em;
margin-bottom: -1.25em; }
Expand Down Expand Up @@ -1480,7 +1480,7 @@ a.button {
right: 1em;
width: 210px;
height: 210px;
background: top left no-repeat url('../img/python-logo-large.png?1646853871') transparent; }
background: top left no-repeat url('../img/python-logo-large.png?1767349471') transparent; }
.psf-widget .widget-title, .psf-widget p, .python-needs-you-widget .widget-title, .python-needs-you-widget p {
margin-right: 34.04255%; }

Expand Down
18 changes: 10 additions & 8 deletions static/sass/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ pre {
/* IE 5.5+ and up */ }

code {
color: #11a611; }
color: #0d870d; }

var {
font-style: italic; }
Expand Down Expand Up @@ -724,6 +724,9 @@ a, a:active, a:visited, a:hover, a:visited:hover {
color: #3776ab;
text-decoration: none; }

table tr td a, table tr td a:active, table tr td a:visited, table tr td a:hover, table tr td a:visited:hover {
color: #3571a3; }

a:hover, a:focus {
color: #1e2933; }

Expand Down Expand Up @@ -1619,7 +1622,7 @@ input#s,
padding: 1.25em 1.5em; }
.slide-code code {
display: inline-block;
color: #11a611; }
color: #0d870d; }
.slide-code code .comment {
color: #666666; }
.slide-code code .output {
Expand Down Expand Up @@ -1932,8 +1935,7 @@ input#s,
background-color: #e6e8ea;
padding: .125em .375em 0;
margin: 0 .25em; }
.text code, .text kbd,
.sidebar-widget code,
.text kbd,
.sidebar-widget kbd {
padding: .125em .375em 0;
margin: 0 -.0625em;
Expand All @@ -1950,7 +1952,7 @@ input#s,
.text pre,
.sidebar-widget pre {
padding: .5em;
border-left: 5px solid #11a611;
border-left: 5px solid #0d870d;
background: #e6e8ea;
-webkit-box-shadow: 0 0 0.5em rgba(0, 0, 0, 0.1) inset;
-moz-box-shadow: 0 0 0.5em rgba(0, 0, 0, 0.1) inset;
Expand Down Expand Up @@ -2266,7 +2268,7 @@ table tfoot {
/* ! ===== Success Stories landing page ===== */
.featured-success-story {
padding: 1.3125em 0;
background: center -230px no-repeat url('../img/success-glow2.png?1646853871') transparent;
background: center -230px no-repeat url('../img/success-glow2.png?1767349471') transparent;
/*blockquote*/ }
.featured-success-story img {
padding: 10px 30px; }
Expand Down Expand Up @@ -3276,11 +3278,11 @@ span.highlighted {
.python .site-headline a:before {
width: 290px;
height: 82px;
content: url('../img/python-logo_print.png?1646853871'); }
content: url('../img/python-logo_print.png?1767349471'); }
.psf .site-headline a:before {
width: 334px;
height: 82px;
content: url('../img/psf-logo_print.png?1646853871'); } }
content: url('../img/psf-logo_print.png?1767349471'); } }
/*
* When we want to review the markup for W3 and similar errors, turn some of these on
* Uses :not selectors a bunch, so only modern browsers will support them
Expand Down
8 changes: 7 additions & 1 deletion static/sass/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ a, a:active, a:visited, a:hover, a:visited:hover {
text-decoration: none;
}

table tr td {
a, a:active, a:visited, a:hover, a:visited:hover {
color: darken($link-color, 2%);
}
}

a:hover, a:focus { color: $link-hover; }

/*modernizr*/ .touch a[href^="tel:"] { border-bottom: 1px dotted $default-color; }
Expand Down Expand Up @@ -953,7 +959,7 @@ $show-baseline-grid-backgrounds: false;
margin: 0 .25em;
}

code, kbd {
kbd {
padding: .125em .375em 0;
margin: 0 -.0625em;
background: $grey-lightest;
Expand Down