Skip to content

maybe fix ci #2870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JacobCoffee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

maybe fix ci #2870

JacobCoffee wants to merge 3 commits into from

Conversation

@JacobCoffee
Copy link
Member

@JacobCoffee JacobCoffee commented Jan 13, 2026

@JacobCoffee JacobCoffee requested a review from ewdurbin as a code owner January 13, 2026 21:26
JacobCoffee
JacobCoffee commented Jan 13, 2026
View reviewed changes
JacobCoffee
JacobCoffee commented Jan 13, 2026
View reviewed changes
@JacobCoffee JacobCoffee requested a review from hugovk January 13, 2026 21:28
@JacobCoffee JacobCoffee enabled auto-merge (squash) January 13, 2026 21:54
@JacobCoffee JacobCoffee disabled auto-merge January 13, 2026 21:55
@JacobCoffee
Copy link
Member Author

JacobCoffee commented Jan 13, 2026

😵‍💫 round and round we go, back to duplicates with the main gate on push.

hugovk
hugovk reviewed Jan 14, 2026
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: #2869 (comment)

Maybe keep the if:s and add one to lint.yml

.github/workflows/ci.yml
Comment on lines +3 to +6
on:
push:
pull_request:
workflow_dispatch:
Copy link
Member

@hugovk hugovk Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) this is identical to the original one-liner:

Suggested change
on:
push:
pull_request:
workflow_dispatch:
on: [push, pull_request, workflow_dispatch]

.github/workflows/lint.yml
Comment on lines +3 to +6
on:
push:
pull_request:
workflow_dispatch:
Copy link
Member

@hugovk hugovk Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
push:
pull_request:
workflow_dispatch:
on: [push, pull_request, workflow_dispatch]

.github/workflows/static.yml
Comment on lines +3 to +6
on:
push:
pull_request:
workflow_dispatch:
Copy link
Member

@hugovk hugovk Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on:
push:
pull_request:
workflow_dispatch:
on: [push, pull_request, workflow_dispatch]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@ewdurbin ewdurbin Awaiting requested review from ewdurbin ewdurbin is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug(CI): CI duplication and messiness

3 participants

@JacobCoffee @hugovk