[tkinter] Annotate few methods #15273
Open
+41
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Jan 14, 2026
Comment on lines
+1035
to
+1038
| @overload | ||
| def wantobjects(self) -> int: ... | ||
| @overload | ||
| def wantobjects(self, wantobjects: int, /) -> None: ... |
Collaborator
There was a problem hiding this comment.
At least for Python 3.12, these are bools:
Python 3.12.3 (main, Jan 8 2026, 11:30:50) [GCC 13.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
>>> tkinter.Tk().wantobjects()
True
Suggested change
| @overload | |
| def wantobjects(self) -> int: ... | |
| @overload | |
| def wantobjects(self, wantobjects: int, /) -> None: ... | |
| @overload | |
| def wantobjects(self) -> bool: ... | |
| @overload | |
| def wantobjects(self, wantobjects: bool, /) -> None: ... |
| def adderrorinfo(self, msg: str, /) -> None: ... | ||
| def call(self, command: Any, /, *args: Any) -> Any: ... | ||
| def createcommand(self, name: str, func, /): ... | ||
| def createcommand(self, name: str, func: Callable[..., object], /) -> None: ... |
Collaborator
There was a problem hiding this comment.
Are you sure that func takes arbitrary arguments? Maybe @Akuli, our resident tkinter expert has some insights. We should at least leave a TODO comment to check this.
| if sys.platform != "win32": | ||
| def createfilehandler(self, file, mask: int, func, /): ... | ||
| def deletefilehandler(self, file, /) -> None: ... | ||
| def createfilehandler(self, file: FileDescriptorLike, mask: int, func: Callable[..., object], /) -> None: ... |
|
|
||
| def createtimerhandler(self, milliseconds: int, func, /): ... | ||
| def dooneevent(self, flags: int = 0, /): ... | ||
| def createtimerhandler(self, milliseconds: int, func: Callable[..., object], /): ... |
Comment on lines
+60
to
+65
| def createcommand(self, name: str, func: Callable[..., object], /) -> None: ... | ||
| if sys.platform != "win32": | ||
| def createfilehandler(self, file, mask: int, func, /): ... | ||
| def deletefilehandler(self, file, /) -> None: ... | ||
| def createfilehandler(self, file: FileDescriptorLike, mask: int, func: Callable[..., object], /) -> None: ... | ||
| def deletefilehandler(self, file: FileDescriptorLike, /) -> None: ... | ||
|
|
||
| def createtimerhandler(self, milliseconds: int, func, /): ... | ||
| def deletecommand(self, name: str, /): ... | ||
| def dooneevent(self, flags: int = 0, /): ... | ||
| def createtimerhandler(self, milliseconds: int, func: Callable[..., object], /): ... |
| def exprlong(self, s: str, /): ... | ||
| def exprstring(self, s: str, /): ... | ||
| def evalfile(self, fileName: str, /) -> str: ... | ||
| def exprboolean(self, s: str, /) -> int: ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| def exprboolean(self, s: str, /) -> int: ... | |
| def exprboolean(self, s: str, /) -> Literal[0, 1]: ... |
| def exprlong(self, s: str, /): ... | ||
| def exprstring(self, s: str, /): ... | ||
| def evalfile(self, fileName: str, /) -> str: ... | ||
| def exprboolean(self, s: str, /) -> int: ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| def exprboolean(self, s: str, /) -> int: ... | |
| def exprboolean(self, s: str, /) -> Literal[0, 1]: ... |
Comment on lines
+93
to
+96
| @overload | ||
| def wantobjects(self) -> int: ... | ||
| @overload | ||
| def wantobjects(self, wantobjects: int, /) -> None: ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| @overload | |
| def wantobjects(self) -> int: ... | |
| @overload | |
| def wantobjects(self, wantobjects: int, /) -> None: ... | |
| @overload | |
| def wantobjects(self) -> bool: ... | |
| @overload | |
| def wantobjects(self, wantobjects: bool, /) -> None: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://github.com/python/cpython/blob/main/Modules/_tkinter.c