More specific type hints for batched(..., strict=True)
#15277
Merged
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liam-DeVoe
force-pushed
the
batch-strict
branch
2 times, most recently
from
a47d169 to
b75d255
Compare
Liam-DeVoe
force-pushed
the
batch-strict
branch
from
b75d255 to
3cc9659
Compare
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reveal_type(next(batched([0, 1], n=2, strict=True)))is nowtuple[int, int]rather thantuple[int, ...]. I went up to 5, which seems to match types for similar classes in itertools.I suppose this is technically a breaking change for anyone who currently annotates as
x: batched[int]? (which is nowx: batched[tuple[int, ...]]). Not sure if this is a big deal.