Skip to content

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Sep 22, 2025

The PR addresses

  1. Llama3 end to end example with complex graph lowering
  2. Removal of hardcoded components of rotary embedding example

@meta-cla meta-cla bot added the cla signed label Sep 22, 2025
@github-actions github-actions bot added component: lowering Issues re: The lowering / preprocessing passes component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Sep 22, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py	2025-09-22 06:34:48.499754+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/utils.py	2025-09-22 06:35:25.106098+00:00
@@ -863,6 +863,6 @@
    return False


def is_thor() -> bool:
    if torch.cuda.get_device_capability() in [(11, 0)]:
-        return True
\ No newline at end of file
+        return True

@apbose apbose mentioned this pull request Sep 22, 2025
7 tasks
@apbose apbose force-pushed the abose/trt_llm_installation_dist branch from 6e99bbc to 7134053 Compare September 22, 2025 22:47
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from 68dcaef to ca70a9d Compare September 22, 2025 23:07
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage labels Sep 22, 2025
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from ca70a9d to 5700249 Compare September 22, 2025 23:14
@github-actions github-actions bot added the component: build system Issues re: Build system label Sep 22, 2025
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from 5700249 to b59abbf Compare September 23, 2025 05:44
@github-actions github-actions bot removed component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: build system Issues re: Build system labels Sep 23, 2025
@apbose apbose force-pushed the abose/trt_llm_installation_dist branch from 3f1fa7e to 54948d9 Compare September 25, 2025 19:33
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from b59abbf to 480fb0a Compare September 25, 2025 20:01
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py	2025-09-25 20:01:17.061900+00:00
+++ /home/runner/work/TensorRT/TensorRT/py/torch_tensorrt/dynamo/distributed/utils.py	2025-09-25 20:01:51.633567+00:00
@@ -100,11 +100,10 @@
        return True

    except Exception as e:
        logger.warning(f"Failed to detect CUDA version: {e}")
        return False
-

    return True


def _cache_root() -> Path:

@apbose apbose force-pushed the abose/trt_llm_installation_dist branch 3 times, most recently from 2bbc423 to 5beefc0 Compare September 25, 2025 22:13
@apbose apbose changed the title Llama distributed example Llama distributed example [WIP] Sep 25, 2025
@apbose apbose force-pushed the abose/trt_llm_installation_dist branch from 5beefc0 to 809c7ee Compare September 26, 2025 00:11
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from 480fb0a to f00d349 Compare September 26, 2025 00:19
@apbose apbose changed the title Llama distributed example [WIP] Llama distributed example Sep 26, 2025
@apbose apbose force-pushed the abose/torchTRT_dist_llama branch from bb6ec7a to dd88017 Compare September 26, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: torch_compile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant