-
Notifications
You must be signed in to change notification settings - Fork 767
Add 'all' option for android flavor #16236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16236
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated FailureAs of commit e9c861e with merge base 793180f ( NEW FAILURE - The following job has failed:
CANCELLED JOB - The following job was cancelled. Please retry:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
|
Nice, couple of questions
|
Minimal increase because we it's really the sum of vulkan + qnn
Will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an "all" flavor option to the Android release artifacts workflow, enabling builds that include all three backend options: xnnpack, qnn, and vulkan.
Key Changes:
- Added "all" as a new choice option for the flavor input parameter
- Updated conditional logic to enable vulkan backend when flavor is "all"
- Updated conditional logic to enable qnn backend when flavor is "all"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
xnnpack + qnn + vulkan
Test plan
CI