Skip to content

Conversation

@kirklandsign
Copy link
Contributor

Summary

xnnpack + qnn + vulkan

Test plan

CI

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16236

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit e9c861e with merge base 793180f (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh
Copy link
Contributor

psiddh commented Dec 13, 2025

Nice, couple of questions

  • what is the APK size increase as a result ?
  • Also did you do any manual testing to confirm that no extra steps are required ?

@kirklandsign
Copy link
Contributor Author

Nice, couple of questions

  • what is the APK size increase as a result ?

Minimal increase because we it's really the sum of vulkan + qnn

  • Also did you do any manual testing to confirm that no extra steps are required ?

Will do

@kirklandsign kirklandsign marked this pull request as ready for review December 18, 2025 20:36
Copilot AI review requested due to automatic review settings December 18, 2025 20:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an "all" flavor option to the Android release artifacts workflow, enabling builds that include all three backend options: xnnpack, qnn, and vulkan.

Key Changes:

  • Added "all" as a new choice option for the flavor input parameter
  • Updated conditional logic to enable vulkan backend when flavor is "all"
  • Updated conditional logic to enable qnn backend when flavor is "all"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kirklandsign kirklandsign merged commit 09bdad7 into main Dec 19, 2025
169 of 172 checks passed
@kirklandsign kirklandsign deleted the android-flavor-all branch December 19, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants