Skip to content

Enable -Wdeprecated-this-capture in gloo/PACKAGE +1 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Nov 24, 2025
Merged

Enable -Wdeprecated-this-capture in gloo/PACKAGE +1 #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gloo/transport/uv/device.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void Device::connectAsListener(
const Address& local,
std::chrono::milliseconds timeout,
ConnectCallback connectCallback) {
defer([=] {
defer([=, this] {
decltype(pendingConnections_)::mapped_type pendingConnection;

// Find pending connection, or stash the connect callback.
Expand Down Expand Up @@ -360,7 +360,7 @@ void Device::connectAsInitiator(
const Address& remote,
std::chrono::milliseconds timeout,
ConnectCallback fn) {
defer([=] {
defer([=, this] {
auto tcp = loop_->resource<libuv::TCP>();
auto timer = loop_->resource<libuv::Timer>();

Expand Down Expand Up @@ -458,7 +458,7 @@ void Device::listenCallback() {

// Wait for remote side to write sequence number.
handle->once<libuv::ReadEvent>(
[=](const libuv::ReadEvent& event, libuv::TCP& handle) {
[=, this](const libuv::ReadEvent& event, libuv::TCP& handle) {
// Sequence number has been read. Either there is an existing
// connection callback for this sequence number, or we'll hold
// on to the handle while we wait for the pair to pass a
Expand Down
2 changes: 1 addition & 1 deletion gloo/transport/uv/pair.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ void Pair::closeWhileHoldingPairLock() {
state_, CONNECTING, "Cannot close pair while waiting on connection");
break;
case CONNECTED:
device_->defer([=] { this->handle_->close(); });
device_->defer([=, this] { this->handle_->close(); });
state_ = CLOSING;
break;
case CLOSING:
Expand Down
Loading