Skip to content

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Oct 29, 2025

PyTorch PR that changed stacktrace summary formatting: pytorch/pytorch#165397.

Example failing CI job: https://github.com/pytorch/helion/actions/runs/18923691664/job/54025942215?pr=1049

  def root_graph_0():
-    # File: .../basic_kernels.py:21 in torch_ops_pointwise, code: out[tile] = torch.sigmoid(torch.add(torch.sin(x[tile]), torch.cos(y[tile])))
+     # File: .../basic_kernels.py:21 in torch_ops_pointwise, code: out[tile] = torch.sigmoid(torch.add(torch.sin(x[tile]), torch.cos(y[tile])))
? +
      x: "i32[1024]" = helion_language__tracing_ops__host_tensor('x')
      block_size_0: "Sym(u0)" = helion_language__tracing_ops__get_symnode('block_size_0')
      load: "i32[u0]" = helion_language_memory_ops_load(x, [block_size_0], None, None);  x = None
      sin: "f32[u0]" = torch.ops.aten.sin.default(load);  load = None
      y: "i32[1024]" = helion_language__tracing_ops__host_tensor('y')
      load_1: "i32[u0]" = helion_language_memory_ops_load(y, [block_size_0], None, None);  y = None
      cos: "f32[u0]" = torch.ops.aten.cos.default(load_1);  load_1 = None
      add: "f32[u0]" = torch.ops.aten.add.Tensor(sin, cos);  sin = cos = None
      sigmoid: "f32[u0]" = torch.ops.aten.sigmoid.default(add);  add = None
      convert_element_type: "i32[u0]" = torch.ops.prims.convert_element_type.default(sigmoid, torch.int32);  sigmoid = None
      out: "i32[1024]" = helion_language__tracing_ops__host_tensor('out')
      store = helion_language_memory_ops_store(out, [block_size_0], convert_element_type, None);  out = block_size_0 = convert_element_type = store = None
      return None

@yf225 yf225 requested review from jansel and oulgen October 29, 2025 23:04
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 29, 2025
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone removed the space?

@yf225
Copy link
Contributor Author

yf225 commented Oct 29, 2025

someone removed the space?

Yes I believe so - and this is probably a better fix: pytorch/pytorch#166590. Will close this PR instead.

@yf225 yf225 closed this Oct 29, 2025
@yf225 yf225 reopened this Oct 30, 2025
@yf225
Copy link
Contributor Author

yf225 commented Oct 30, 2025

@oulgen I realized Sherlock's change (pytorch/pytorch#165397) actually made the formatted graph code look nicer (no more misaligned indentation on the comment), so I will probably merge this PR instead

@yf225 yf225 merged commit 182d16f into main Oct 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants