Ignore passed in config when force autotune is turned on #1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
force-pushed
the
oulgen/stack/166
branch
from
46a82ba to
9e9d14e
Compare
meta-cla
bot
added
the
CLA Signed
yf225
approved these changes
Oct 31, 2025
| return self._config | ||
| if self.settings.force_autotune: | ||
| # If force autotune is enabled, do not pick an implicit config | ||
| return None |
Contributor
There was a problem hiding this comment.
Curious should we move this before if self._config is not None: above?
Contributor
Author
There was a problem hiding this comment.
self._config set means we already autotuned in this process, so i was thinking we shouldnt autotune twice in the same process
tianrengao
pushed a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Ignore passed in config when force autotune is turned on
Fixes #1059