Validate user provided settings #947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
choijon5
force-pushed
the
settings_validation
branch
from
d9b521d to
8b048a6
Compare
choijon5
force-pushed
the
settings_validation
branch
2 times, most recently
from
c0bef41 to
29b9304
Compare
Some invalid settings could make the compiler hang.
choijon5
force-pushed
the
settings_validation
branch
2 times, most recently
from
e5b50f6 to
388fa82
Compare
|
@jansel looks like you added a lot of checks here: 6a2a5a2#diff-a24a8c490d66acd0226f70af3e8b5a392c4ef8cb6975140e25e373793c951771 Do you still want this to be merged? I thought using post_init might be a bit cleaner, but yours has more checks. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that all user provided setting values are of the correct type/values to ensure there's no unexpected behavior.