Skip to content

[BugFix] Fix schemes and refactor collectors to make them readable #3226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 6, 2025
Merged

[BugFix] Fix schemes and refactor collectors to make them readable #3226

merged 9 commits into from
Nov 6, 2025

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Oct 28, 2025 •
edited
Loading

@vmoens
Update
e913282 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3226

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Oct 28, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
57f3b2f 
ghstack-source-id: 85de0e9
Pull-Request: #3226
@vmoens vmoens mentioned this pull request Oct 28, 2025
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 28, 2025
@vmoens
Update
e97e406 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Oct 28, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
54fd748 
ghstack-source-id: 8345a75
Pull-Request: #3226
@github-actions
Copy link

github-actions bot commented Oct 28, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}26$. Worsened: $\large\color{#d91a1a}11$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 85.1089μs 84.0827μs 11.8931 KOps/s 11.7105 KOps/s $\color{#35bf28}+1.56\%$
test_tensor_to_bytestream_speed[torch.save] 0.1458ms 0.1436ms 6.9660 KOps/s 6.8794 KOps/s $\color{#35bf28}+1.26\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1151s 0.1149s 8.7070 Ops/s 8.8228 Ops/s $\color{#d91a1a}-1.31\%$
test_tensor_to_bytestream_speed[numpy] 2.8478μs 2.8327μs 353.0226 KOps/s 349.5731 KOps/s $\color{#35bf28}+0.99\%$
test_tensor_to_bytestream_speed[safetensors] 43.6607μs 43.0362μs 23.2363 KOps/s 22.3394 KOps/s $\color{#35bf28}+4.01\%$
test_simple 0.6641s 0.5709s 1.7515 Ops/s 1.7355 Ops/s $\color{#35bf28}+0.92\%$
test_transformed 1.2244s 1.1328s 0.8827 Ops/s 0.8807 Ops/s $\color{#35bf28}+0.23\%$
test_serial 1.6582s 1.6547s 0.6043 Ops/s 0.5934 Ops/s $\color{#35bf28}+1.85\%$
test_parallel 1.0939s 1.0613s 0.9422 Ops/s 0.9011 Ops/s $\color{#35bf28}+4.57\%$
test_step_mdp_speed[True-True-True-True-True] 0.1604ms 43.5698μs 22.9517 KOps/s 22.5304 KOps/s $\color{#35bf28}+1.87\%$
test_step_mdp_speed[True-True-True-True-False] 53.6910μs 24.9351μs 40.1041 KOps/s 39.5105 KOps/s $\color{#35bf28}+1.50\%$
test_step_mdp_speed[True-True-True-False-True] 54.0810μs 24.9797μs 40.0325 KOps/s 37.8400 KOps/s $\textbf{\color{#35bf28}+5.79\%}$
test_step_mdp_speed[True-True-True-False-False] 41.9100μs 13.7049μs 72.9668 KOps/s 68.8238 KOps/s $\textbf{\color{#35bf28}+6.02\%}$
test_step_mdp_speed[True-True-False-True-True] 90.8520μs 47.3027μs 21.1404 KOps/s 20.7095 KOps/s $\color{#35bf28}+2.08\%$
test_step_mdp_speed[True-True-False-True-False] 0.4413ms 27.3890μs 36.5111 KOps/s 34.8007 KOps/s $\color{#35bf28}+4.91\%$
test_step_mdp_speed[True-True-False-False-True] 0.4437ms 27.9139μs 35.8245 KOps/s 34.6265 KOps/s $\color{#35bf28}+3.46\%$
test_step_mdp_speed[True-True-False-False-False] 0.4271ms 16.3547μs 61.1443 KOps/s 57.9270 KOps/s $\textbf{\color{#35bf28}+5.55\%}$
test_step_mdp_speed[True-False-True-True-True] 86.5220μs 50.3660μs 19.8547 KOps/s 19.2774 KOps/s $\color{#35bf28}+2.99\%$
test_step_mdp_speed[True-False-True-True-False] 0.4417ms 29.8245μs 33.5294 KOps/s 31.6572 KOps/s $\textbf{\color{#35bf28}+5.91\%}$
test_step_mdp_speed[True-False-True-False-True] 0.4393ms 28.0330μs 35.6723 KOps/s 35.0142 KOps/s $\color{#35bf28}+1.88\%$
test_step_mdp_speed[True-False-True-False-False] 0.4331ms 16.4289μs 60.8684 KOps/s 56.0879 KOps/s $\textbf{\color{#35bf28}+8.52\%}$
test_step_mdp_speed[True-False-False-True-True] 85.5910μs 52.3123μs 19.1160 KOps/s 18.8150 KOps/s $\color{#35bf28}+1.60\%$
test_step_mdp_speed[True-False-False-True-False] 0.4430ms 32.7542μs 30.5304 KOps/s 30.0512 KOps/s $\color{#35bf28}+1.59\%$
test_step_mdp_speed[True-False-False-False-True] 0.4417ms 30.3412μs 32.9585 KOps/s 32.4803 KOps/s $\color{#35bf28}+1.47\%$
test_step_mdp_speed[True-False-False-False-False] 0.5305ms 19.1792μs 52.1397 KOps/s 51.3623 KOps/s $\color{#35bf28}+1.51\%$
test_step_mdp_speed[False-True-True-True-True] 85.0920μs 49.8051μs 20.0783 KOps/s 19.9425 KOps/s $\color{#35bf28}+0.68\%$
test_step_mdp_speed[False-True-True-True-False] 0.4379ms 30.3948μs 32.9004 KOps/s 31.2476 KOps/s $\textbf{\color{#35bf28}+5.29\%}$
test_step_mdp_speed[False-True-True-False-True] 2.4751ms 32.2952μs 30.9643 KOps/s 30.1124 KOps/s $\color{#35bf28}+2.83\%$
test_step_mdp_speed[False-True-True-False-False] 0.4227ms 18.4727μs 54.1340 KOps/s 50.0560 KOps/s $\textbf{\color{#35bf28}+8.15\%}$
test_step_mdp_speed[False-True-False-True-True] 91.5310μs 53.0276μs 18.8581 KOps/s 18.5071 KOps/s $\color{#35bf28}+1.90\%$
test_step_mdp_speed[False-True-False-True-False] 0.4502ms 33.3739μs 29.9636 KOps/s 29.2855 KOps/s $\color{#35bf28}+2.32\%$
test_step_mdp_speed[False-True-False-False-True] 0.4440ms 35.0102μs 28.5631 KOps/s 29.7237 KOps/s $\color{#d91a1a}-3.90\%$
test_step_mdp_speed[False-True-False-False-False] 0.4389ms 21.1889μs 47.1946 KOps/s 46.3466 KOps/s $\color{#35bf28}+1.83\%$
test_step_mdp_speed[False-False-True-True-True] 85.9330μs 56.4093μs 17.7276 KOps/s 17.4535 KOps/s $\color{#35bf28}+1.57\%$
test_step_mdp_speed[False-False-True-True-False] 0.4498ms 36.6521μs 27.2836 KOps/s 27.6382 KOps/s $\color{#d91a1a}-1.28\%$
test_step_mdp_speed[False-False-True-False-True] 0.4436ms 34.5127μs 28.9748 KOps/s 28.3272 KOps/s $\color{#35bf28}+2.29\%$
test_step_mdp_speed[False-False-True-False-False] 0.4349ms 20.9431μs 47.7485 KOps/s 45.2802 KOps/s $\textbf{\color{#35bf28}+5.45\%}$
test_step_mdp_speed[False-False-False-True-True] 0.1350ms 55.9568μs 17.8709 KOps/s 17.4277 KOps/s $\color{#35bf28}+2.54\%$
test_step_mdp_speed[False-False-False-True-False] 76.4010μs 37.8385μs 26.4281 KOps/s 25.8666 KOps/s $\color{#35bf28}+2.17\%$
test_step_mdp_speed[False-False-False-False-True] 73.8610μs 36.1684μs 27.6484 KOps/s 27.1195 KOps/s $\color{#35bf28}+1.95\%$
test_step_mdp_speed[False-False-False-False-False] 55.5510μs 23.1410μs 43.2133 KOps/s 41.8850 KOps/s $\color{#35bf28}+3.17\%$
test_values[generalized_advantage_estimate-True-True] 10.3688ms 9.3897ms 106.4996 Ops/s 104.6540 Ops/s $\color{#35bf28}+1.76\%$
test_values[vec_generalized_advantage_estimate-True-True] 13.2694ms 11.3292ms 88.2673 Ops/s 57.0062 Ops/s $\textbf{\color{#35bf28}+54.84\%}$
test_values[td0_return_estimate-False-False] 0.2538ms 0.1269ms 7.8815 KOps/s 8.4569 KOps/s $\textbf{\color{#d91a1a}-6.80\%}$
test_values[td1_return_estimate-False-False] 25.8450ms 25.4510ms 39.2912 Ops/s 38.0376 Ops/s $\color{#35bf28}+3.30\%$
test_values[vec_td1_return_estimate-False-False] 13.1859ms 11.5187ms 86.8152 Ops/s 56.7870 Ops/s $\textbf{\color{#35bf28}+52.88\%}$
test_values[td_lambda_return_estimate-True-False] 39.1314ms 37.9252ms 26.3677 Ops/s 25.8041 Ops/s $\color{#35bf28}+2.18\%$
test_values[vec_td_lambda_return_estimate-True-False] 11.8994ms 11.3707ms 87.9451 Ops/s 56.7474 Ops/s $\textbf{\color{#35bf28}+54.98\%}$
test_gae_speed[generalized_advantage_estimate-False-1-512] 8.5820ms 8.2317ms 121.4823 Ops/s 123.9940 Ops/s $\color{#d91a1a}-2.03\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.6865ms 1.4350ms 696.8543 Ops/s 674.7056 Ops/s $\color{#35bf28}+3.28\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.5463ms 0.3930ms 2.5448 KOps/s 2.5687 KOps/s $\color{#d91a1a}-0.93\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 24.2934ms 23.6056ms 42.3628 Ops/s 31.8465 Ops/s $\textbf{\color{#35bf28}+33.02\%}$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 1.8590ms 1.7227ms 580.4709 Ops/s 584.7289 Ops/s $\color{#d91a1a}-0.73\%$
test_dqn_speed[False-None] 7.0025ms 1.3961ms 716.2787 Ops/s 690.6474 Ops/s $\color{#35bf28}+3.71\%$
test_dqn_speed[False-backward] 1.9876ms 1.8659ms 535.9382 Ops/s 513.7568 Ops/s $\color{#35bf28}+4.32\%$
test_dqn_speed[True-None] 1.0885ms 0.5239ms 1.9086 KOps/s 1.9217 KOps/s $\color{#d91a1a}-0.68\%$
test_dqn_speed[True-backward] 1.0159ms 0.9488ms 1.0540 KOps/s 875.0888 Ops/s $\textbf{\color{#35bf28}+20.45\%}$
test_dqn_speed[reduce-overhead-None] 0.9296ms 0.5070ms 1.9724 KOps/s 1.9024 KOps/s $\color{#35bf28}+3.68\%$
test_dqn_speed[reduce-overhead-backward] 0.9673ms 0.9336ms 1.0712 KOps/s 951.4260 Ops/s $\textbf{\color{#35bf28}+12.59\%}$
test_ddpg_speed[False-None] 3.3028ms 2.8753ms 347.7953 Ops/s 352.3015 Ops/s $\color{#d91a1a}-1.28\%$
test_ddpg_speed[False-backward] 4.1729ms 4.0306ms 248.1025 Ops/s 251.5557 Ops/s $\color{#d91a1a}-1.37\%$
test_ddpg_speed[True-None] 1.8049ms 1.3736ms 727.9957 Ops/s 719.7842 Ops/s $\color{#35bf28}+1.14\%$
test_ddpg_speed[True-backward] 2.4138ms 2.3348ms 428.2965 Ops/s 416.7398 Ops/s $\color{#35bf28}+2.77\%$
test_ddpg_speed[reduce-overhead-None] 1.7733ms 1.3686ms 730.6556 Ops/s 732.9921 Ops/s $\color{#d91a1a}-0.32\%$
test_ddpg_speed[reduce-overhead-backward] 2.3933ms 2.3117ms 432.5740 Ops/s 424.9766 Ops/s $\color{#35bf28}+1.79\%$
test_sac_speed[False-None] 8.1434ms 7.7355ms 129.2738 Ops/s 129.4854 Ops/s $\color{#d91a1a}-0.16\%$
test_sac_speed[False-backward] 11.2512ms 10.8944ms 91.7905 Ops/s 91.8285 Ops/s $\color{#d91a1a}-0.04\%$
test_sac_speed[True-None] 2.3524ms 2.1159ms 472.6069 Ops/s 401.0706 Ops/s $\textbf{\color{#35bf28}+17.84\%}$
test_sac_speed[True-backward] 4.1197ms 3.9996ms 250.0276 Ops/s 249.8220 Ops/s $\color{#35bf28}+0.08\%$
test_sac_speed[reduce-overhead-None] 2.5142ms 2.1046ms 475.1464 Ops/s 469.9324 Ops/s $\color{#35bf28}+1.11\%$
test_sac_speed[reduce-overhead-backward] 4.1510ms 4.0490ms 246.9750 Ops/s 244.1283 Ops/s $\color{#35bf28}+1.17\%$
test_redq_speed[False-None] 10.8004ms 10.2182ms 97.8641 Ops/s 97.0593 Ops/s $\color{#35bf28}+0.83\%$
test_redq_speed[False-backward] 18.3027ms 17.7127ms 56.4568 Ops/s 56.2582 Ops/s $\color{#35bf28}+0.35\%$
test_redq_speed[True-None] 4.6742ms 4.4593ms 224.2486 Ops/s 227.1136 Ops/s $\color{#d91a1a}-1.26\%$
test_redq_speed[True-backward] 10.3965ms 10.0608ms 99.3952 Ops/s 104.0866 Ops/s $\color{#d91a1a}-4.51\%$
test_redq_speed[reduce-overhead-None] 4.7005ms 4.4234ms 226.0697 Ops/s 228.9521 Ops/s $\color{#d91a1a}-1.26\%$
test_redq_speed[reduce-overhead-backward] 10.3673ms 10.0841ms 99.1660 Ops/s 103.7219 Ops/s $\color{#d91a1a}-4.39\%$
test_redq_deprec_speed[False-None] 11.5780ms 10.8644ms 92.0434 Ops/s 94.5996 Ops/s $\color{#d91a1a}-2.70\%$
test_redq_deprec_speed[False-backward] 16.3727ms 15.7607ms 63.4489 Ops/s 66.2911 Ops/s $\color{#d91a1a}-4.29\%$
test_redq_deprec_speed[True-None] 4.0528ms 3.6345ms 275.1393 Ops/s 286.3878 Ops/s $\color{#d91a1a}-3.93\%$
test_redq_deprec_speed[True-backward] 7.9358ms 7.6585ms 130.5732 Ops/s 142.0929 Ops/s $\textbf{\color{#d91a1a}-8.11\%}$
test_redq_deprec_speed[reduce-overhead-None] 4.1843ms 3.6763ms 272.0101 Ops/s 274.9794 Ops/s $\color{#d91a1a}-1.08\%$
test_redq_deprec_speed[reduce-overhead-backward] 7.7877ms 7.5911ms 131.7328 Ops/s 116.0440 Ops/s $\textbf{\color{#35bf28}+13.52\%}$
test_td3_speed[False-None] 8.0685ms 7.7985ms 128.2299 Ops/s 127.4996 Ops/s $\color{#35bf28}+0.57\%$
test_td3_speed[False-backward] 11.2314ms 10.6016ms 94.3251 Ops/s 94.4011 Ops/s $\color{#d91a1a}-0.08\%$
test_td3_speed[True-None] 2.1140ms 1.7914ms 558.2378 Ops/s 543.1571 Ops/s $\color{#35bf28}+2.78\%$
test_td3_speed[True-backward] 3.7749ms 3.6291ms 275.5517 Ops/s 228.1550 Ops/s $\textbf{\color{#35bf28}+20.77\%}$
test_td3_speed[reduce-overhead-None] 1.8429ms 1.7713ms 564.5424 Ops/s 558.0096 Ops/s $\color{#35bf28}+1.17\%$
test_td3_speed[reduce-overhead-backward] 4.1307ms 3.6303ms 275.4600 Ops/s 273.9926 Ops/s $\color{#35bf28}+0.54\%$
test_cql_speed[False-None] 28.9233ms 25.9030ms 38.6056 Ops/s 38.5454 Ops/s $\color{#35bf28}+0.16\%$
test_cql_speed[False-backward] 41.1882ms 35.6042ms 28.0865 Ops/s 27.8053 Ops/s $\color{#35bf28}+1.01\%$
test_cql_speed[True-None] 15.1618ms 12.3281ms 81.1154 Ops/s 79.6202 Ops/s $\color{#35bf28}+1.88\%$
test_cql_speed[True-backward] 18.7904ms 18.2911ms 54.6713 Ops/s 54.5761 Ops/s $\color{#35bf28}+0.17\%$
test_cql_speed[reduce-overhead-None] 15.2800ms 12.4841ms 80.1018 Ops/s 76.7585 Ops/s $\color{#35bf28}+4.36\%$
test_cql_speed[reduce-overhead-backward] 19.0656ms 18.6715ms 53.5575 Ops/s 53.9948 Ops/s $\color{#d91a1a}-0.81\%$
test_a2c_speed[False-None] 5.7074ms 5.3405ms 187.2498 Ops/s 179.9685 Ops/s $\color{#35bf28}+4.05\%$
test_a2c_speed[False-backward] 13.0027ms 11.8200ms 84.6025 Ops/s 79.5998 Ops/s $\textbf{\color{#35bf28}+6.28\%}$
test_a2c_speed[True-None] 3.9303ms 3.6974ms 270.4571 Ops/s 263.0328 Ops/s $\color{#35bf28}+2.82\%$
test_a2c_speed[True-backward] 8.9299ms 8.6980ms 114.9685 Ops/s 112.9984 Ops/s $\color{#35bf28}+1.74\%$
test_a2c_speed[reduce-overhead-None] 4.0806ms 3.7153ms 269.1539 Ops/s 264.2658 Ops/s $\color{#35bf28}+1.85\%$
test_a2c_speed[reduce-overhead-backward] 9.1832ms 8.9586ms 111.6249 Ops/s 110.5663 Ops/s $\color{#35bf28}+0.96\%$
test_ppo_speed[False-None] 6.2391ms 5.9256ms 168.7590 Ops/s 166.6070 Ops/s $\color{#35bf28}+1.29\%$
test_ppo_speed[False-backward] 12.9117ms 12.6429ms 79.0955 Ops/s 77.8343 Ops/s $\color{#35bf28}+1.62\%$
test_ppo_speed[True-None] 3.8775ms 3.6721ms 272.3235 Ops/s 256.1573 Ops/s $\textbf{\color{#35bf28}+6.31\%}$
test_ppo_speed[True-backward] 9.5748ms 8.6241ms 115.9543 Ops/s 116.3996 Ops/s $\color{#d91a1a}-0.38\%$
test_ppo_speed[reduce-overhead-None] 3.8191ms 3.6672ms 272.6843 Ops/s 272.3599 Ops/s $\color{#35bf28}+0.12\%$
test_ppo_speed[reduce-overhead-backward] 9.2359ms 8.7956ms 113.6927 Ops/s 108.2061 Ops/s $\textbf{\color{#35bf28}+5.07\%}$
test_reinforce_speed[False-None] 4.8529ms 4.6368ms 215.6663 Ops/s 213.9453 Ops/s $\color{#35bf28}+0.80\%$
test_reinforce_speed[False-backward] 7.8565ms 7.4466ms 134.2897 Ops/s 132.4101 Ops/s $\color{#35bf28}+1.42\%$
test_reinforce_speed[True-None] 3.4129ms 2.8884ms 346.2127 Ops/s 338.1914 Ops/s $\color{#35bf28}+2.37\%$
test_reinforce_speed[True-backward] 8.0772ms 7.7275ms 129.4074 Ops/s 124.2768 Ops/s $\color{#35bf28}+4.13\%$
test_reinforce_speed[reduce-overhead-None] 3.2649ms 2.8625ms 349.3437 Ops/s 350.4012 Ops/s $\color{#d91a1a}-0.30\%$
test_reinforce_speed[reduce-overhead-backward] 8.2730ms 8.0337ms 124.4760 Ops/s 121.1099 Ops/s $\color{#35bf28}+2.78\%$
test_iql_speed[False-None] 25.7690ms 20.3680ms 49.0966 Ops/s 49.7323 Ops/s $\color{#d91a1a}-1.28\%$
test_iql_speed[False-backward] 36.8332ms 31.3859ms 31.8615 Ops/s 33.7200 Ops/s $\textbf{\color{#d91a1a}-5.51\%}$
test_iql_speed[True-None] 9.3136ms 8.6534ms 115.5612 Ops/s 117.9178 Ops/s $\color{#d91a1a}-2.00\%$
test_iql_speed[True-backward] 17.3906ms 16.9807ms 58.8903 Ops/s 60.4175 Ops/s $\color{#d91a1a}-2.53\%$
test_iql_speed[reduce-overhead-None] 8.9438ms 8.7059ms 114.8652 Ops/s 113.3433 Ops/s $\color{#35bf28}+1.34\%$
test_iql_speed[reduce-overhead-backward] 18.0798ms 17.4555ms 57.2886 Ops/s 54.5007 Ops/s $\textbf{\color{#35bf28}+5.12\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.5876ms 6.0316ms 165.7933 Ops/s 166.8366 Ops/s $\color{#d91a1a}-0.63\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.6536ms 0.3512ms 2.8475 KOps/s 3.6141 KOps/s $\textbf{\color{#d91a1a}-21.21\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.6146ms 0.3210ms 3.1149 KOps/s 3.8955 KOps/s $\textbf{\color{#d91a1a}-20.04\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.1485ms 5.7835ms 172.9061 Ops/s 174.5461 Ops/s $\color{#d91a1a}-0.94\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 2.1867ms 0.3432ms 2.9140 KOps/s 3.4073 KOps/s $\textbf{\color{#d91a1a}-14.48\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.6117ms 0.3227ms 3.0987 KOps/s 3.0034 KOps/s $\color{#35bf28}+3.17\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6174ms 1.4006ms 713.9694 Ops/s 829.4389 Ops/s $\textbf{\color{#d91a1a}-13.92\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5993ms 1.3051ms 766.2444 Ops/s 890.2605 Ops/s $\textbf{\color{#d91a1a}-13.93\%}$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.3198ms 5.8975ms 169.5632 Ops/s 168.4370 Ops/s $\color{#35bf28}+0.67\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8872ms 0.5163ms 1.9369 KOps/s 2.0363 KOps/s $\color{#d91a1a}-4.88\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8226ms 0.4877ms 2.0503 KOps/s 2.2025 KOps/s $\textbf{\color{#d91a1a}-6.91\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 6.1880ms 5.7684ms 173.3581 Ops/s 173.9589 Ops/s $\color{#d91a1a}-0.35\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.9225ms 0.2786ms 3.5887 KOps/s 2.5981 KOps/s $\textbf{\color{#35bf28}+38.13\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.4699ms 0.2593ms 3.8562 KOps/s 2.8689 KOps/s $\textbf{\color{#35bf28}+34.41\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.9437ms 5.6838ms 175.9398 Ops/s 174.7774 Ops/s $\color{#35bf28}+0.67\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 1.8986ms 0.2804ms 3.5668 KOps/s 2.8389 KOps/s $\textbf{\color{#35bf28}+25.64\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5493ms 0.3221ms 3.1041 KOps/s 3.9218 KOps/s $\textbf{\color{#d91a1a}-20.85\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 9.1641ms 6.0731ms 164.6597 Ops/s 169.4303 Ops/s $\color{#d91a1a}-2.82\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 2.1720ms 0.4789ms 2.0880 KOps/s 2.0351 KOps/s $\color{#35bf28}+2.60\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.6365ms 0.4229ms 2.3646 KOps/s 2.3393 KOps/s $\color{#35bf28}+1.08\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 0.4880s 14.6750ms 68.1430 Ops/s 195.4538 Ops/s $\textbf{\color{#d91a1a}-65.14\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 11.1634ms 2.0937ms 477.6211 Ops/s 484.2034 Ops/s $\color{#d91a1a}-1.36\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 2.0345ms 1.0920ms 915.7545 Ops/s 834.7705 Ops/s $\textbf{\color{#35bf28}+9.70\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 8.4718ms 5.0437ms 198.2687 Ops/s 195.4563 Ops/s $\color{#35bf28}+1.44\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 6.6369ms 2.0102ms 497.4714 Ops/s 492.6365 Ops/s $\color{#35bf28}+0.98\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 8.9627ms 1.2191ms 820.2923 Ops/s 834.1157 Ops/s $\color{#d91a1a}-1.66\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 0.4256s 13.6452ms 73.2859 Ops/s 57.0862 Ops/s $\textbf{\color{#35bf28}+28.38\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 9.6169ms 2.1127ms 473.3361 Ops/s 487.0852 Ops/s $\color{#d91a1a}-2.82\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 1.2064ms 1.0070ms 993.0096 Ops/s 997.9186 Ops/s $\color{#d91a1a}-0.49\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 35.8423ms 33.0568ms 30.2509 Ops/s 30.3171 Ops/s $\color{#d91a1a}-0.22\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.2574ms 17.4648ms 57.2580 Ops/s 57.7282 Ops/s $\color{#d91a1a}-0.81\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.7672ms 33.9342ms 29.4688 Ops/s 29.3272 Ops/s $\color{#35bf28}+0.48\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.0026ms 17.4113ms 57.4339 Ops/s 57.5303 Ops/s $\color{#d91a1a}-0.17\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 40.1671ms 35.1136ms 28.4790 Ops/s 28.2624 Ops/s $\color{#35bf28}+0.77\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 20.4504ms 18.7242ms 53.4069 Ops/s 53.6008 Ops/s $\color{#d91a1a}-0.36\%$

vmoens added a commit that referenced this pull request Oct 28, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
6258a2c 
ghstack-source-id: 8345a75
Pull-Request: #3226
@vmoens
Update
87047ec 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Oct 29, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
a13c7cb 
ghstack-source-id: 8557132
Pull-Request: #3226
@vmoens
Update
b59b374 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 3, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
35cd9de 
ghstack-source-id: fe515ee
Pull-Request: #3226
@vmoens vmoens added the bug Something isn't working label Nov 3, 2025
@vmoens
Update
2d9fec3 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 3, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
a1a0414 
ghstack-source-id: cd1c4cc
Pull-Request: #3226
This was referenced Nov 5, 2025
Merged
Merged
vmoens added 2 commits November 6, 2025 14:09
@vmoens
Update
0d63bf9 
[ghstack-poisoned]
@vmoens
Update
33ef6b4 
[ghstack-poisoned]
@vmoens vmoens mentioned this pull request Nov 6, 2025
Merged
vmoens added 2 commits November 6, 2025 17:29
@vmoens
Update
e4e89c5 
[ghstack-poisoned]
@vmoens
Update
dcf2521 
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 6, 2025
@vmoens
[BugFix] Fix schemes and refactor collectors to make them readable
364e038 
ghstack-source-id: 1a20b74
Pull-Request: #3226
@vmoens vmoens merged commit dcf2521 into gh/vmoens/171/base Nov 6, 2025
50 of 61 checks passed
@vmoens vmoens deleted the gh/vmoens/171/head branch November 6, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens