-
Couldn't load subscription status.
- Fork 560
Add helper functions getDefaultXLAGenerator and createXLAGenerator to XLA random number generator #9682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…` to XLA random number generator
|
@qihqi do you know why do i always get build timeout? it builds successfully locally on my machine. i am not able to find any clue of the cause from the build log. please take a look |
|
@ysiraichi @qihqi can you please take a look. thanks! |
This might be because your PR is not from a branch on this PyTorch/XLA repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I think that it looks good overall.
Could you add a few C++ tests and check everything is working?
Add helper functions getDefaultXLAGenerator and createXLAGenerator to XLA random number generator
These helper functions will be used with XLA hook later.
Refer to #9159