Skip to content

Conversation

@iwknow
Copy link
Collaborator

@iwknow iwknow commented Oct 20, 2025

Add helper functions getDefaultXLAGenerator and createXLAGenerator to XLA random number generator

These helper functions will be used with XLA hook later.

Refer to #9159

@iwknow
Copy link
Collaborator Author

iwknow commented Oct 22, 2025

@qihqi do you know why do i always get build timeout? it builds successfully locally on my machine. i am not able to find any clue of the cause from the build log. please take a look

@iwknow
Copy link
Collaborator Author

iwknow commented Oct 24, 2025

@ysiraichi @qihqi can you please take a look. thanks!

@ysiraichi
Copy link
Collaborator

do you know why do i always get build timeout?

This might be because your PR is not from a branch on this PyTorch/XLA repository.
That causes the CI not to use the remote cache.
I'm currently working on using GitHub cache for mitigating that #9659.

Copy link
Collaborator

@ysiraichi ysiraichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I think that it looks good overall.
Could you add a few C++ tests and check everything is working?

@ysiraichi ysiraichi mentioned this pull request Oct 28, 2025
2 tasks
@iwknow iwknow requested a review from ysiraichi October 29, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants