Skip to content

Conversation

crush-wu
Copy link
Contributor

PR Details

Add 4 stock chart support for AddChart function

Description

Add stock chart support for Excelize, include 4 kinds of box and whisker stock charts: "High-Low-Close", "Open-High-Low-Close", "Volume-High-Low-Close", "Volume-Open-High-Low-Close".

Related Issue

None related issue

Motivation and Context

OSPP project

How Has This Been Tested

TODO: add unit tests

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2025
@xuri xuri added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2025
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.24%. Comparing base (2e1d05f) to head (992d124).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2177   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          32       32           
  Lines       30581    30626   +45     
=======================================
+ Hits        30350    30395   +45     
  Misses        153      153           
  Partials       78       78           
Flag Coverage Δ
unittests 99.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 9e0c94e into qax-os:master Sep 2, 2025
17 checks passed
@xuri xuri added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2025
@xuri xuri moved this to Features in Excelize v2.10.0 Sep 2, 2025
xuri added a commit to xuri/excelize-doc that referenced this pull request Sep 30, 2025
- Docs for support create 4 kinds of box and whisker stock charts: "High-Low-Close", "Open-High-Low-Close", "Volume-High-Low-Close", "Volume-Open-High-Low-Close" (qax-os/excelize#2177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Features
Development

Successfully merging this pull request may close these issues.

2 participants