Skip to content

Conversation

userdocs
Copy link
Contributor

@userdocs userdocs commented Sep 1, 2025

Update all actions to full commit sha of latest tag to mitigate supply chain attacks. This was done using renovate but dependabot should be able to maintain the updates in the same format once it's converted.

It is advised by github https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions to do this.

All actions are updated to latest release tag sha with comment of semvar version

@userdocs

This comment was marked as outdated.

Update all actions to full commit sha of latest tag to mitigate supply chain attacks. This was done using renovate but dependabot should be able to maintain the updates in the same format once it's converted.
@Chocobo1
Copy link
Member

Chocobo1 commented Sep 5, 2025

I thought about it but I don't think it is worth it. I'm not going to meticulously check every hash is correct every time it updates (monthly). Even hash update it is done automatically by bot, some human still has to verify it, isn't? And it won't help if the upstream repo already contains undetected malicious commits or leaked write access. This PR only guards against branch/tag changes which is not the main problem for a compromised repo.

@userdocs
Copy link
Contributor Author

userdocs commented Sep 5, 2025

I think full hash of full semvar would be a requirement of https://docs.github.com/en/code-security/supply-chain-security/understanding-your-software-supply-chain/immutable-releases

So if people started doing that, an existing tag or release cannot be modified.

You can maybe just sit on the pr until immutable-releases are out and see if it works for that?

@Chocobo1 Chocobo1 added the CI Issues/PRs related to CI label Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/PRs related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants