Skip to content

Conversation

@even-even
Copy link

@even-even even-even commented Nov 28, 2025

User description

https://docs.pydantic.dev/latest/migration/#changes-to-pydanticbasemodel
dict() in pydanticV2 was deprecated. In this PR I was changed dict() to model_dump() method.


PR Type

Bug fix


Description

  • Replace deprecated Pydantic dict() method with model_dump()

  • Update three occurrences in similar issue indexing methods

  • Ensure Pydantic V2 compatibility across codebase


Diagram Walkthrough

flowchart LR
  A["Pydantic V2 Deprecation"] -->|"Replace dict() calls"| B["model_dump() method"]
  B -->|"Applied to"| C["pr_similar_issue.py"]
  C -->|"3 locations updated"| D["Compatibility achieved"]
Loading

File Walkthrough

Relevant files
Bug fix
pr_similar_issue.py
Update deprecated Pydantic dict() calls to model_dump()   

pr_agent/tools/pr_similar_issue.py

  • Replaced corpus.dict() with corpus.model_dump() in
    _update_index_with_issues() method
  • Replaced corpus.dict() with corpus.model_dump() in
    _update_table_with_issues() method
  • Replaced corpus.dict() with corpus.model_dump() in
    _update_qdrant_with_issues() method
  • All three changes maintain identical functionality while using
    Pydantic V2 API
+3/-3     

@qodo-merge-for-open-source
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Consistent Naming Conventions

Objective: All new variables, functions, and classes must follow the project's established naming
standards

Status: Passed

No Dead or Commented-Out Code

Objective: Keep the codebase clean by ensuring all submitted code is active and necessary

Status: Passed

Robust Error Handling

Objective: Ensure potential errors and edge cases are anticipated and handled gracefully throughout
the code

Status: Passed

Single Responsibility for Functions

Objective: Each function should have a single, well-defined responsibility

Status: Passed

When relevant, utilize early return

Objective: In a code snippet containing multiple logic conditions (such as 'if-else'), prefer an
early return on edge cases than deep nesting

Status: Passed

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-for-open-source
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant