-
Notifications
You must be signed in to change notification settings - Fork 166
libdiag: Add runtime dependency on diag-router #1321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
reviewed
Dec 22, 2025
lumag
approved these changes
Dec 22, 2025
Add RDEPENDS on diag-router package as libdiag operates in a client-server architecture where the library connects to the diag-router daemon at runtime. Signed-off-by: Jairaj Solanki <[email protected]>
1264fb3 to
6765dda
Compare
Test run workflowTest jobs for commit 6765dda
|
Test Results 12 files - 2 24 suites - 4 29m 45s ⏱️ - 3m 8s Results for commit 6765dda. ± Comparison against base commit 3e7e427. This pull request removes 5 tests.♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit 6765dda
|
Test run workflowTest jobs for commit 6765dda
|
Test run workflowTest jobs for commit 6765dda
|
sbanerjee-quic
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RDEPENDS on diag-router package as libdiag operates in a client-server architecture where the library connects to the diag-router daemon at runtime.