Skip to content

Conversation

@pavoljuhas
Copy link
Collaborator

  • check/pylint - enforce pylint for benchmarks

  • pylint - add missing copyright notice

  • check/mypy - enforce type check for benchmarks

  • Skip type-check for ASV benchmark scripts
    Not worth fixing as these will be replaced by pytest-benchmark-s.

Related to #7796

@github-actions github-actions bot added the size: S 10< lines changed <50 label Jan 7, 2026
Not worth fixing as these will be replace by pytest-benchmark-s.
@pavoljuhas pavoljuhas force-pushed the ci-lint-and-type-check-benchmarks branch from 85396d3 to 7b7a2fe Compare January 7, 2026 01:38
@pavoljuhas pavoljuhas marked this pull request as ready for review January 7, 2026 01:42
@pavoljuhas pavoljuhas requested review from a team and vtomole as code owners January 7, 2026 01:42
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (e96726a) to head (b770847).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7828   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        1102     1102           
  Lines       98772    98772           
=======================================
+ Hits        98350    98351    +1     
+ Misses        422      421    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mhucka mhucka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas enabled auto-merge January 7, 2026 21:06
@pavoljuhas pavoljuhas added this pull request to the merge queue Jan 7, 2026
Merged via the queue into quantumlib:main with commit a8efbc5 Jan 7, 2026
38 checks passed
@pavoljuhas pavoljuhas deleted the ci-lint-and-type-check-benchmarks branch January 7, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants