Add unit test for QSimSimulator.get_seed#1027
Open
mhucka wants to merge 2 commits intoquantumlib:mainfrom
Open
Add unit test for QSimSimulator.get_seed#1027mhucka wants to merge 2 commits intoquantumlib:mainfrom
mhucka wants to merge 2 commits intoquantumlib:mainfrom
Conversation
Added a new test case `test_get_seed` to `qsimcirq_tests/qsimcirq_test.py` to verify: - The returned seed is within the expected [0, 2^31 - 1) range. - The simulator is deterministic when initialized with a fixed seed. - Subsequent calls to `get_seed` return different values.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new test, test_get_seed, in qsimcirq_test.py to validate the QSimSimulator.get_seed() method. The test covers the seed's value range, determinism when initialized with the same seed, and the expectation that subsequent calls to get_seed() yield different values. A potential flakiness issue was noted in the test for subsequent calls, as asserting sim.get_seed() != sim.get_seed() relies on a statistical unlikelihood rather than a guarantee, suggesting a more robust approach of generating multiple seeds and asserting their diversity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new test case
test_get_seedtoqsimcirq_tests/qsimcirq_test.pyto verify:get_seedreturn different values.