Add test for add_op_to_circuit unsupported gate#1028
Draft
mhucka wants to merge 3 commits intoquantumlib:mainfrom
Draft
Add test for add_op_to_circuit unsupported gate#1028mhucka wants to merge 3 commits intoquantumlib:mainfrom
add_op_to_circuit unsupported gate#1028mhucka wants to merge 3 commits intoquantumlib:mainfrom
Conversation
Added a test case for the ValueError raised when an unsupported gate is passed to add_op_to_circuit. Also improved the library code by adding an explicit check for unsupported gates early in the function.
…est-9353109264355801897
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a validation check in qsimcirq/qsim_circuit.py to ensure that only supported gates are added to a circuit. If an unsupported gate is encountered, a ValueError is now raised. A corresponding test case, test_add_op_to_circuit_unsupported_gate, has been added to qsimcirq_tests/qsimcirq_test.py to verify this new error handling. There is no feedback to provide as no review comments were given.
…ted gate Added a test case for the ValueError raised when an unsupported gate is passed to add_op_to_circuit. Refactored the ValueError message to use an f-string as requested. Improved the library code by adding an explicit check for unsupported gates early in the function. Corrected formatting using black to comply with project guidelines.
github-actions
bot
added
size: L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test case for the
ValueErrorraised when an unsupported gate is passed toadd_op_to_circuit. Also improved the library code by adding an explicit check for unsupported gates early in the function.