Remove redundant to_normal_order after SetState in custatevecExStateVectorSetState#1029
Open
mhucka wants to merge 1 commit intoquantumlib:mainfrom
Conversation
…StateVecEx::Copy`. Based on cuStateVecEx documentation, `custatevecExStateVectorSetState` respects the current wire ordering of the state vector. Therefore, calling `to_normal_order()` to physically rearrange the state is not logically required after initialization from a host buffer, and it might even be undesirable if the caller intends to keep a specific permutation for performance. Removed the `to_normal_order()` calls and associated TODO comments from both `Copy` overloads in `lib/vectorspace_custatevecex.h`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on cuStateVecEx documentation,
custatevecExStateVectorSetStaterespects the current wire ordering of the state vector. Therefore, callingto_normal_order()to physically rearrange the state is not logically required after initialization from a host buffer, and it might even be undesirable if the caller intends to keep a specific permutation for performance.Removed the
to_normal_order()calls and associated TODO comments from bothCopyoverloads inlib/vectorspace_custatevecex.h.