Conversation
Release v1.282.0
Release v1.282.0 Add QBridge contract (Vottun) Add Oracle Documentation Fix bug on loading execution fee after seamless epoch change Fix problem during loading of assets from snapshot Adjust TICK_DURATION_FOR_ALLOCATION_MS and TRANSACTION_SPARSENESS Increase ADDITION_SOLUTION_THRESHOLD_DEFAULT to 74800
philippwerner
left a comment
philippwerner
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Overall, it looks good to me. Just the following comments:
Why did you change the DebugInformationFormat in the platform libraries? Is there any problem with the "ProgramDatabase" setting that is fixed by changing the value to "OldStyle"? If there isn't a good reason, please undo the changes in the *.vcxproj files.
If management rights are transferred to QUTIL, it also must offer a way to transfer the rights back to other contracts. So please add a procedure TransferShareManagementRights for that purpose to QUTIL.
|
I'm sorry. An error occurred during the build process, so I had no choice but to change it that way. I forgot that I shouldn't push the related files when I push. |
double-k-3033
force-pushed
the
feature/qutil
branch
from
c794718 to
e8f0f14
Compare
double-k-3033
force-pushed
the
feature/qutil
branch
from
e8f0f14 to
9ce0779
Compare
src/contracts/QUtil.h
Outdated
| // no fee | ||
| if (qpi.invocationReward() > 0) | ||
| { | ||
| qpi.transfer(qpi.invocator(), qpi.invocationReward()); |
There was a problem hiding this comment.
did you run the node and test this? (transferring shares back to QX)
src/contracts/QUtil.h
Outdated
| * - GetPollsByCreator: Retrieve all poll IDs created by a specific address | ||
| * - GetCurrentPollId: Retrieve the current poll ID | ||
| */ | ||
| * A collection of useful functions for smart contract on Qubic: |
There was a problem hiding this comment.
why do you add a single space to hundred lines in this commit? it makes very hard to review your new changes
| qpi.transfer(qpi.invocator(), qpi.invocationReward()); | ||
| if (qpi.invocationReward() > 0) | ||
| { | ||
| qpi.transfer(qpi.invocator(), qpi.invocationReward()); |
There was a problem hiding this comment.
did you test this function (send mgmt right back to QX) by running a node?
double-k-3033
force-pushed
the
feature/qutil
branch
from
51ca19e to
e20242b
Compare
5 participants
No description provided.