Enable CB for vlms with multiple images and multiple prompts #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-mamta
requested review from
ochougul,
quic-amitraj,
quic-hemagnih and
quic-rishinr
as code owners
quic-rishinr
force-pushed
the
cb_vlms
branch
2 times, most recently
from
8dd6395 to
b41bd72
Compare
Signed-off-by: Mamta Singh <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Mamta Singh <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Asmita Goswami <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Mohit Soni <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: vbaddi <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Mohit Soni <[email protected]> Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
Signed-off-by: Rishin Raj <[email protected]>
quic-amitraj
requested changes
Nov 3, 2025
quic-amitraj
reviewed
Nov 3, 2025
Signed-off-by: Mohit Soni <[email protected]>
quic-amitraj
requested changes
Nov 3, 2025
Signed-off-by: Rishin Raj <[email protected]>
quic-hemagnih
approved these changes
Nov 4, 2025
| del self.execObj | ||
| self.program.deactivate() | ||
| if self.is_active: | ||
| del self.execObj |
There was a problem hiding this comment.
NIT pick, we should always have a cleanup method declared for execObj, else it may lead to silent memory leaks. Just deleting the object may lead to hidden memory leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.