Refactor recent stats #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces code getting handle and fetching responses with function calls
…ctor-recent-stats
- calculate number of pages from initial endpoint response -- calcluate_n_pages() - fetch response content for each page and append to list -- fetch_pages_content()
add documentation
…ctor-recent-stats
…ctor-recent-stats
remove duplicated ###Marked for edit section code replace edit_url fetch with fetch_response_as_json code replace for loop over edit_url pages with a do.call statement
Merge remote-tracking branch 'origin/refactor-recent-stats' into refactor-recent-stats # Conflicts: # weblate/Recent Changes/Recent changes.R
…frame for each page (and styler)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses closes #56
The changes address the requested improvements to
Recent changes.R:Improvements included:
./weblate/R/translated_dataandmark_dataare derived using two phases: (1) fetch the content from the API, and (2) extract and wrangle the data.match()has been used where applicable.stringrdependency has been avoided