NA + 1i is not syntactic literal

[jonthegeek]

Fixes #1828.

[jonthegeek]

Evidently the NA + 1i behavior changed in R 4.4. I'll take a closer look when I get a minute.

[jonthegeek]

Technically the test should fail on R < 4.4; before the change, NA + 1i became NA, which is a syntactic literal. Maybe split that last test into two versions with skip_if_not(as.numeric_version(paste0(R.version$major, ".", R.version$minor)) >= "4.4")) and `skip_if(as.numeric_version(paste0(R.version$major, ".", R.version$minor)) < "4.4")? Is there a more idiomatic way to express that in rlang?

[lionel-]

@jonthegeek You can use:

testthat::skip_if_not_installed("base", "4.4")

[jonthegeek]

@jonthegeek You can use:

testthat::skip_if_not_installed("base", "4.4")

Oh wow that makes sense and seems obvious now that I know it, but I wouldn't have thought of it! Thanks! Update incoming.

[lionel-]

Awesome, thanks a lot for your follow-up!