Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r_pairlist_find()was showing up in my Instruments profiles as not being inlined. It is used in some of the deepest layers of vctrs viar_dim()andr_class()through the following:r_dim()r_attrib_get()r_pairlist_get()r_pairlist_find()r_dim()itself is used on every iteration ofvec_size_common()when computing thevec_size()of an object.It's definitely a simple enough loop that we can inline it, and after inlining it does disappear from the Instruments profile