Add support for models which use non-primary key columns for lookup (i.e. external_id columns) #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelfranca
requested changes
Sep 18, 2025
lib/global_id/identification.rb
Outdated
| end | ||
| end | ||
|
|
||
| def global_id_method |
There was a problem hiding this comment.
Do we need this method? We can just set the column to be :id by default.
There was a problem hiding this comment.
👍 I updated the implementation to use the class_attribute extension from ActiveSupport and brought consistency to the naming
tylerwillingham
commented
Sep 18, 2025
Comment on lines
+165
to
+169
| if model_class.global_id_column == :id | ||
| model_class.find gid.model_id | ||
| else | ||
| model_class.find_by model_class.global_id_column => gid.model_id | ||
| end |
There was a problem hiding this comment.
💭 Simplifying on find_by (or find_by!) for ActiveRecord users feels nice, but I stopped short of doing that because I recall seeing that globalid doesn't want to make ORM assumptions
tylerwillingham
force-pushed
the
twilling/alternative-primary-keys-plus-locator
branch
from
85e19f0 to
57d724b
Compare
This allows overriding the column used to define GIDs
Because of Identification.global_id_column, we can keep this internal API much cleaner and avoid mucking with hash state to pass around this column
`Model.primary_key` is actually irrelevant to this feature, the only thing that matters is the model method. For composite keys, or primary keys not named "id", we still get the important value from `Model#id`, the only time we don't is when we need to use a non-PK column.
tylerwillingham
force-pushed
the
twilling/alternative-primary-keys-plus-locator
branch
from
57d724b to
13a4a69
Compare
…tribute This simplifies the implementation's API substantially by defining both instance and class methods, and rails/globalid already depends on ActiveSupport
tylerwillingham
force-pushed
the
twilling/alternative-primary-keys-plus-locator
branch
from
13a4a69 to
b551218
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this proposal,
GlobalID::Identificationwould implementglobal_id_columnto set the desired column for GlobalID to reference on a per-model basisi.e.
I think this is particularly useful for teams in the process of migrating off of auto-incremented primary keys, or are interested in using unsigned GIDs with some level of obscurity that's not attainable without starting to make a bigger change like actually implementing UUIDs as PKs
This PR extends beyond #185's initial implementation and add's support to the default locator to use these alternative columns for look-up