docs: update readme yaml config example #273
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@djmb would you review this? |
djmb
reviewed
Nov 6, 2025
README.md
Outdated
| store_options: | ||
| <<: *default_store_options | ||
| max_entries: <%= 256.gigabytes %> | ||
| max_entries: 10_000_000 # default is null |
Collaborator
There was a problem hiding this comment.
Could we change this to max_size: <%= 256.gigabytes %> instead? The max_size option if more accurate at estimating the cache size and it matches the value above.
Collaborator
|
Thanks @andimrob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very minor change updates a mistake I noticed in the readme for the yaml config of solid cache for
max_entries