Add Ruby 3.4 to CI matrix #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it attemps to install bundler 2.4.21 while Ruby version is 3.4. https://github.com/rails/thor/actions/runs/13782104138/job/38542040661?pr=899 ``` /opt/hostedtoolcache/Ruby/3.4.2/x64/bin/gem install bundler -v 2.4.21 Successfully installed bundler-2.4.21 1 gem installed Took 0.37 seconds ```
|
Confirmed the bundler version installed as expected. |
This commit addresses the following error:
```ruby
% ruby -v
ruby 3.5.0dev (2025-03-11T00:00:47Z master 47c3ae6962) +PRISM [arm64-darwin24]
~/src/github.com/rails/thor %
% bundle exec rspec ./spec/actions/create_link_spec.rb
/Users/yahonda/src/github.com/rails/thor/spec/helper.rb:18: warning: rdoc used to be loaded from the standard library, but is not part of the default gems since Ruby 3.5.0.
You can add rdoc to your Gemfile or gemspec to fix this error.
An error occurred while loading ./spec/actions/create_link_spec.rb. - Did you mean?
rspec ./spec/actions/create_file_spec.rb
Failure/Error: require "rdoc"
LoadError:
cannot load such file -- rdoc
No examples found.
Finished in 0.00002 seconds (files took 0.11832 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
Coverage report generated for RSpec to /Users/yahonda/src/github.com/rails/thor/coverage.
Line Coverage: 34.9% (511 / 1464)
[Coveralls] Outside the CI environment, not sending data.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
%
```
Refer to:
ruby/ruby#12577
https://bugs.ruby-lang.org/issues/20309
|
Addressed CI against Ruby 3.5 aka head by adding the % ruby -v
ruby 3.5.0dev (2025-03-11T00:00:47Z master 47c3ae6962) +PRISM [arm64-darwin24]
% bundle exec rspec ./spec/actions/create_link_spec.rb
/Users/yahonda/src/github.com/rails/thor/spec/helper.rb:18: warning: rdoc used to be loaded from the standard library, but is not part of the default gems since Ruby 3.5.0.
You can add rdoc to your Gemfile or gemspec to fix this error.
An error occurred while loading ./spec/actions/create_link_spec.rb. - Did you mean?
rspec ./spec/actions/create_file_spec.rb
Failure/Error: require "rdoc"
LoadError:
cannot load such file -- rdoc
# ./spec/helper.rb:18:in '<top (required)>'
# ./spec/actions/create_link_spec.rb:1:in '<top (required)>'
No examples found.
Finished in 0.00002 seconds (files took 0.11832 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
Coverage report generated for RSpec to /Users/yahonda/src/github.com/rails/thor/coverage.
Line Coverage: 34.9% (511 / 1464)
[Coveralls] Outside the CI environment, not sending data.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
%
|
This commit addresses the following error:
```ruby
% ruby -v
ruby 3.5.0dev (2025-03-11T00:00:47Z master 47c3ae6962) +PRISM [arm64-darwin24]
~/src/github.com/rails/thor % vi GE
% bundle exec rspec ./spec/line_editor_spec.rb
An error occurred while loading ./spec/line_editor_spec.rb. - Did you mean?
rspec ./spec/line_editor/basic_spec.rb
Failure/Error: require "readline"
LoadError:
cannot load such file -- readline
No examples found.
Finished in 0.00002 seconds (files took 0.18631 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
Coverage report generated for RSpec to /Users/yahonda/src/github.com/rails/thor/coverage.
Line Coverage: 41.55% (920 / 2214)
[Coveralls] Outside the CI environment, not sending data.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
```
Refer to https://bugs.ruby-lang.org/issues/20309
|
Addressed CI failure against Ruby 3.5 aka head by adding rdoc and readline to Gemfile that will be separated as bundled gems. |
|
Refer to ruby/ruby#12624 that moves readline to bundled gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Ruby 3.4 to CI matrix.