Fix MacOS build and add MacOS CI #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 9, 2025 10:15
MacOS build was not working likely because there Criterion was not on the default path and CMake was not propagating the path it found
CMake has been specifying openblas - this has been changed to BLAS::BLAS which should work with any BLAS
Linking against BLAS has worked on Linux, but MacOS BLAS seems to be structured differently, requiring explicit linking against LAPACK
The Apple Accelerate library is likely to need more work, so for now we'll only test with OpenBLAS
RastislavTuranyi
added
CI/CD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the MacOS CMake build by:
IMPORTED_TARGETto propagate PkgConfig pathsBLAS::BLASinstead of specifyingopenblas)Additionally, adds a MacOS CI pipeline that runs the tests.
However, one thing to note is that this currently doesn't work with Apple's own BLAS library (Accelerate), probably because it doesn't export Fortran-style symbols for some LAPACK routines (
dgemqrt_,dgeqrt_) - fixing this will likely require more substantial efforts. For now, OpenBLAS seems to work just fine. @haldaas, can you please check that this branch works on your mac?