Skip to content

Conversation

@enneitex
Copy link

Summary

Fixes #15249

this change adds support for displaying CRDs fields definition similar to what is already done for native resources.
It also fixes the kind displayed for fields like pod.spec.containers.args which are []string but the UI previously showed []Object

I tested manually with a few CRDs (see video below)

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

before:

before.mov

after:

after.mov

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

scrollTop() {
this.$refs.main.$el.scrollTop = 0;
if (this.$refs.main?.$el) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, I hit Uncaught TypeError: Cannot read properties of null (reading '$el') once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explain drawer does not show crd spec description

1 participant