Skip to content

Conversation

@houhoucoop
Copy link
Contributor

@houhoucoop houhoucoop commented Oct 22, 2025

Summary

Fixes #15169

Occurred changes and/or fixed issues

  • On the Longhorn overview page, the description text has the same color as --body-bg, making it invisible in both light and dark themes.

Technical notes summary

  • Remove the color from the CSS so that the description uses the var(--link) color

Areas or cases that should be tested

  • istio page
  • longhorn overview page
  • neuvector page

Areas which could experience regressions

N/A

Screenshot/Video

Before
Screenshot 2025-10-22 at 1 15 15 PM (2)

After
Screenshot 2025-10-22 at 5 03 40 PM (2)

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

@houhoucoop houhoucoop self-assigned this Oct 22, 2025
@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.13.0 milestone Oct 22, 2025
@houhoucoop houhoucoop changed the title fix: card description color fix: correct description text color in multiple overview pages Oct 22, 2025
@houhoucoop houhoucoop changed the title fix: correct description text color in multiple overview pages fix: correct description text color in overview pages Oct 22, 2025
@houhoucoop houhoucoop requested a review from a110605 October 23, 2025 05:53
Copy link
Member

@rak-phillip rak-phillip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Good catch!

--secondary is one of those color variables that was used, but never defined in the original theme. We've run into issues with this in other places like inputs.

@houhoucoop houhoucoop merged commit 9bf6e64 into rancher:master Oct 27, 2025
166 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update colors for modern theme

2 participants